Skip to content

Conversation

@K4ryuu
Copy link
Contributor

@K4ryuu K4ryuu commented Nov 29, 2025

Description

Fixes the following targeting issues:

  • Added option to change the case sensitiveness of name targeting
  • The SteamID convert returned 0 for names, that always matched bots

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring (no functional changes)
  • Performance improvement
  • Test coverage improvement
  • Build/CI improvement

Related Issues

Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)

Changes Made

  • Native changes (C++)
  • Managed Changes (C#)
  • API additions/modifications
  • Memory management improvements
  • Network handling changes
  • SDK updates
  • Build system changes

Detailed Changes

List the specific changes made:

  • Added the new optional param to IPlayerManager.cs
  • Removed the unused converter from PlayerManagerService.cs
  • Added the new optional param to PlayerManagerService.cs
  • Changed the SteamID convert to use CSteamID instead

Testing

Test Environment

  • OS: SteamRT3 > Debian 11 (Bullseye)
  • Game: Counter-Strike 2

Test Cases

Describe the test cases you've run:

Breaking Changes

List any breaking changes and migration steps:

Performance Impact

  • No performance impact
  • Positive performance impact
  • Negative performance impact (explain below)
  • Performance impact unknown

Details:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots/Videos (if applicable)

Add screenshots or videos demonstrating the changes:

Additional Notes

Any additional information, context, or notes for reviewers:


For Maintainers

  • Code review completed
  • Tests pass
  • Ready to merge

@skuzzis skuzzis merged commit 7ccca7e into swiftly-solution:beta Nov 29, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in SwiftlyS2 - Roadmap Nov 29, 2025
@samyycX
Copy link
Collaborator

samyycX commented Nov 29, 2025

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants