Fix Xcode warnings #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not enough aware of the projects that use So I will eventually decide, on my own, to raise the iOS deployment target of this project. Fighting Xcode and the Apple policy on backward compatibility is not a position that one can hold for long. I wait for the author and users of this library to chime in and express their eventual rationale against such a bump. |
Xcode insists on bumping IPHONEOS_DEPLOYMENT_TARGET, but this is not acceptable for this project which has lower minimum requirements. So there will remain warnings.
groue
force-pushed
the
fix-Xcode-warnings
branch
from
4a21b3a to
fe05b40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes as many Xcode warnings as possible:
Xcode also warns because IPHONEOS_DEPLOYMENT_TARGET is not iOS 12. Well, warn as much as you want, Xcode: this pull requests does not change the requirements of this repository.