Skip to content

Benchmarks: Prevent cross-module inlining of f32/f64 @_extern(wasm) functions #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krodak merged 1 commit into from
Feb 12, 2026
Merged

Benchmarks: Prevent cross-module inlining of f32/f64 @_extern(wasm) functions #628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions Sources/JavaScriptKit/BridgeJSIntrinsics.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,22 +723,30 @@ where Self: RawRepresentable, RawValue: _BridgedSwiftTypeLoweredIntoSingleWasmCo

#if arch(wasm32)
@_extern(wasm, module: "bjs", name: "swift_js_push_f32")
@_spi(BridgeJS) public func _swift_js_push_f32(_ value: Float32)
private func _swift_js_push_f32_extern(_ value: Float32)
#else
@_spi(BridgeJS) public func _swift_js_push_f32(_ value: Float32) {
private func _swift_js_push_f32_extern(_ value: Float32) {
_onlyAvailableOnWasm()
}
#endif

@_spi(BridgeJS) @inline(never) public func _swift_js_push_f32(_ value: Float32) {
_swift_js_push_f32_extern(value)
}

#if arch(wasm32)
@_extern(wasm, module: "bjs", name: "swift_js_push_f64")
@_spi(BridgeJS) public func _swift_js_push_f64(_ value: Float64)
private func _swift_js_push_f64_extern(_ value: Float64)
#else
@_spi(BridgeJS) public func _swift_js_push_f64(_ value: Float64) {
private func _swift_js_push_f64_extern(_ value: Float64) {
_onlyAvailableOnWasm()
}
#endif

@_spi(BridgeJS) @inline(never) public func _swift_js_push_f64(_ value: Float64) {
_swift_js_push_f64_extern(value)
}

#if arch(wasm32)
@_extern(wasm, module: "bjs", name: "swift_js_pop_i32")
@_spi(BridgeJS) public func _swift_js_pop_i32() -> Int32
Expand All @@ -750,22 +758,30 @@ where Self: RawRepresentable, RawValue: _BridgedSwiftTypeLoweredIntoSingleWasmCo

#if arch(wasm32)
@_extern(wasm, module: "bjs", name: "swift_js_pop_f32")
@_spi(BridgeJS) public func _swift_js_pop_f32() -> Float32
private func _swift_js_pop_f32_extern() -> Float32
#else
@_spi(BridgeJS) public func _swift_js_pop_f32() -> Float32 {
private func _swift_js_pop_f32_extern() -> Float32 {
_onlyAvailableOnWasm()
}
#endif

@_spi(BridgeJS) @inline(never) public func _swift_js_pop_f32() -> Float32 {
_swift_js_pop_f32_extern()
}

#if arch(wasm32)
@_extern(wasm, module: "bjs", name: "swift_js_pop_f64")
@_spi(BridgeJS) public func _swift_js_pop_f64() -> Float64
private func _swift_js_pop_f64_extern() -> Float64
#else
@_spi(BridgeJS) public func _swift_js_pop_f64() -> Float64 {
private func _swift_js_pop_f64_extern() -> Float64 {
_onlyAvailableOnWasm()
}
#endif

@_spi(BridgeJS) @inline(never) public func _swift_js_pop_f64() -> Float64 {
_swift_js_pop_f64_extern()
}

// MARK: Struct bridging helpers (JS-side lowering/raising)

#if arch(wasm32)
Expand Down