BridgeJS: Fix property codegen using unqualified type name for namespace-nested classes#682
Merged
krodak merged 1 commit intoswiftwasm:mainfrom Feb 27, 2026
Conversation
kateinoigakukun
approved these changes
Feb 27, 2026
Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSCodegenTests/EnumNamespace.swift
Show resolved
Hide resolved
4c869e0 to
330a339
Compare
…ace-nested classes
330a339 to
816325f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Property getter/setter thunks for classes nested inside
@JS enumnamespaces used the bare class name (e.g.Converter) instead of the qualified name (e.g.Utils.Converter) for the_selfparameter type. This causes compilation failures when another type with the same name exists at module scope.Methods, constructors, deinit, and extensions already used
swiftCallName(qualified). Only properties were broken.Fix: Add a
swiftCallNamecomputed property toPropertyRenderingContextand use it for the_selfparameter in both getter and setter codegen, matching what methods already do.Before (generated getter):
After:
Tests: added
precision: Intinstance property to theUtils.Converterclass in both the snapshot test input and the e2e runtime test. All 104 plugin tests and 141 e2e tests pass.