Upgrade rxjs to ^7.4.0 #2074
Open
Upgrade rxjs to ^7.4.0 #2074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
is this going to be merged? |
|
please merge it asap |
|
+1 |
|
Please merge |
|
+1. Needed for using ngx-datatables with latest versions of Angular. |
|
Need this please. Also seems the peer dep is still ng11? |
you can use --force to install it, but test it before going productive. For me it doesn't break. |
|
Please merge |
|
+1 |
1 similar comment
|
+1 |
|
Hi Team, Please merge this PR ASAP. Lot of people are waiting for this update it seems. |
At this point, I honestly believe there's no "Team" behind this anymore. This project seems abandoned by maintainers. |
|
Any update here? |
|
Can this be merged? |
|
Please find some time to merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #2073, #2042
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Since the upgrade to angular 13, installing the package warns that one needs to install
^rxjs@6.6.3when one already hasrxjs@7.4.0, which is what angular 13+ now runs on.What is the new behavior?
Now that we've upgraded the package to support
rxjs@^7.4.0, Angular 13+ users shouldn't see false positive warnings when installing the package.Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: