Use labels instead of env #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker recommends this format explicitly in their label documentation. See: https://docs.docker.com/engine/userguide/labels-custom-metadata/
src/docker/event_handler_test.go
Outdated
|
|
||
| Context("When a start event is received", func() { | ||
| Context("When the container does not have an IAM_PROFILE set", func() { | ||
| Context("When the container does not have an com.swipely.iam-docker.iam-profile set", func() { |
There was a problem hiding this comment.
just for the sake of readability, probably don't need the an here.
|
👍 |
|
Who is this "swipely" you speak of? |
Contributor
Author
|
Unfortunately still our GitHub name, and therefore go import path :( |
|
👍 |
iderdik
pushed a commit
to iderdik/iam-docker
that referenced
this pull request
Mar 29, 2017
Adding Health Check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adamjt @bfulton @tlunter
Use Docker Container Labels instead of environment variables for setting the
IAM_PROFILE.Labels are specifically meant for external metadata, which is a better fit for this use case.