Skip to content

Patches XSS vulnerability found in relay handlers #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Patches XSS vulnerability found in relay handlers #485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f906105
Patches XSS vulnerability found in relay handlers
petruki Mar 31, 2024
b2a67a2
chore: Improved request validation for the client/criteria route
petruki Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/client/relay/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ const agent = async (url) => {
};

export async function resolveNotification(relay, entry, environment) {
const url = relay.endpoint[environment];
const header = createHeader(relay.auth_prefix, relay.auth_token, environment);
const env = Object.keys(relay.endpoint).find(e => e === environment);
const url = relay.endpoint[env];
const header = createHeader(relay.auth_prefix, relay.auth_token, env);

if (relay.method === RelayMethods.GET) {
get(url, createParams(entry), header);
Expand All @@ -22,8 +23,9 @@ export async function resolveNotification(relay, entry, environment) {
export async function resolveValidation(relay, entry, environment) {
let response;

const url = relay.endpoint[environment];
const header = createHeader(relay.auth_prefix, relay.auth_token, environment);
const env = Object.keys(relay.endpoint).find(e => e === environment);
const url = relay.endpoint[env];
const header = createHeader(relay.auth_prefix, relay.auth_token, env);

if (relay.method === RelayMethods.GET) {
response = await get(url, createParams(entry), header);
Expand Down
8 changes: 6 additions & 2 deletions src/routers/client-api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { resolveCriteria, checkDomain } from '../client/resolvers';
import { getConfigs } from '../services/config';
import { body, check, query } from 'express-validator';
import { clientLimiter } from '../middleware/limiter';
import { StrategiesType } from '../models/config-strategy';

const router = new express.Router();

Expand All @@ -14,8 +15,11 @@ const router = new express.Router();
// GET /check?key=KEY&showStrategy=true
// GET /check?key=KEY&bypassMetric=true
router.post('/criteria', componentAuth, clientLimiter, [
query('key').isLength({ min: 1 }),
body('entry.*.input').isString()
query('key').isLength({ min: 1 }).withMessage('Key is required'),
body('entry').isArray().optional().withMessage('Entry must be an array'),
body('entry.*.input').isString(),
body('entry.*.strategy').isString()
.custom(value => Object.values(StrategiesType).includes(value)).withMessage('Invalid strategy type')
], validate, checkConfig, checkConfigComponent, async (req, res) => {
try {
const environment = req.environment;
Expand Down
40 changes: 40 additions & 0 deletions tests/client-api.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,46 @@ describe('Testing criteria [REST] ', () => {
expect(req.body.result).toBe(false);
});

test('CLIENT_SUITE - Should NOT return success on a entry-based CRITERIA response - Entry not an array', async () => {
await request(app)
.post(`/criteria?key=${keyConfig}&showReason=true&showStrategy=true`)
.set('Authorization', `Bearer ${token}`)
.send({
entry: {
strategy: StrategiesType.VALUE,
input: 'USER_1'
}})
.expect(422);
});

test('CLIENT_SUITE - Should NOT return success on a entry-based CRITERIA response - Invalid Strategy', async () => {
await request(app)
.post(`/criteria?key=${keyConfig}&showReason=true&showStrategy=true`)
.set('Authorization', `Bearer ${token}`)
.send({
entry: [
{
strategy: 'INVALID_STRATEGY',
input: 'USER_1'
}
]})
.expect(422);
});

test('CLIENT_SUITE - Should NOT return success on a entry-based CRITERIA response - Missing key', async () => {
await request(app)
.post('/criteria?showReason=true&showStrategy=true')
.set('Authorization', `Bearer ${token}`)
.send({
entry: [
{
strategy: StrategiesType.VALUE,
input: 'USER_1'
}
]})
.expect(422);
});

test('CLIENT_SUITE - Should NOT return success on a entry-based CRITERIA response - Component not registered', async () => {
// Given
const component = new Component({
Expand Down