Fixes Slack integration service query

src/services/common.js

@@ -1,6 +1,13 @@
 import { NotFoundError } from '../exceptions/index.js';
 
 export function response(element, onErrorMessage) {
-    if (!element) throw new NotFoundError(onErrorMessage);
+    if (!element) {
+        throw new NotFoundError(onErrorMessage);
+    }
+
     return element;
-}
+}
+
+export function isQueryValid(where) {
+    return Object.values(where).some(value => value != null);
+}

src/services/slack.js

@@ -7,6 +7,7 @@ import { getDomainById, updateDomainVersion } from './domain.js';
 import { getEnvironment } from './environment.js';
 import { getGroupConfig } from './group-config.js';
 import { containsValue } from '../helpers/index.js';
+import { isQueryValid } from './common.js';
 
 /**
  * Validates if ticket already exists, if so, return it.
@@ -63,6 +64,10 @@ export async function getSlackOrError(where) {
 }
 
 export async function getSlack(where) {
+    if (!isQueryValid(where)) {
+        throw new NotFoundError('Slack installation not found - no valid query provided');
+    }
+
     const query = Slack.findOne();
 
     if (where.id) query.where('_id', where.id);

tests/fixtures/db_api.js

@@ -227,6 +227,7 @@ export const slack = {
         incoming_webhook_channel_id : 'CHANNEL_ID'
     },
 };
+domainDocument.integrations = { slack: slack._id };
 
 export const setupDatabase = async () => {
     await ConfigStrategy.deleteMany().exec();

tests/slack.test.js

@@ -146,6 +146,26 @@ describe('Slack Installation', () => {
             mock1_slack_installation.installation_payload.incoming_webhook_channel);
     });
 
+    test('SLACK_SUITE - Should NOT query installation by Domain - Domain has no Slack integration', async () => {
+        //given
+        const domain = await getDomainById(domainId);
+        const slackId = domain.integrations.slack;
+        domain.integrations.slack = null;
+        await domain.save();
+
+        //test
+        const response = await request(app)
+            .get(`/slack/v1/installation/${String(domainId)}`)
+            .set('Authorization', `Bearer ${adminMasterAccountToken}`)
+            .send().expect(404);
+
+        expect(response.body.error).toBe('Slack installation not found - no valid query provided');
+
+        //teardown
+        domain.integrations.slack = slackId;
+        await domain.save();
+    });
+
     test('SLACK_SUITE - Should NOT query installation by Domain - Domain not found', async () => {
         await request(app)
             .get(`/slack/v1/installation/${new mongoose.Types.ObjectId()}`)