Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request refactors several resolver functions in
src/aggregator/resolvers.jsto improve input validation and ensure proper data types when querying MongoDB. The main changes involve converting string IDs toObjectId, formatting input fields, and enforcing enum values for certain arguments. These updates help prevent errors and ensure consistency across database queries.Input validation and transformation improvements:
_idfields in resolver functions are now explicitly converted toTypes.ObjectIdbefore being used in MongoDB queries, reducing the risk of type-related errors. [1] [2] [3] [4]keyandnamefields are now formatted using theformatInputhelper to enforce consistent casing, underscores, and allowed spaces as appropriate for each resolver. [1] [2] [3]Enum enforcement:
strategyandoperationarguments inresolveConfigStrategyare now validated against theStrategiesTypeandOperationsTypeenums, ensuring only valid values are used in queries.Imports update:
Types,OperationsType,StrategiesType, andformatInputto support the above changes.