Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request introduces a new feature for validating switcher keys both locally (against a snapshot) and remotely (via the API), along with comprehensive error handling and associated tests. Additionally, there are minor updates to workflow files and some code cleanup.
New switcher validation feature:
CheckSwitchersfunction at both the package and client level to validate that provided switcher keys exist, either in the local snapshot or via the remote API, depending on the client's mode. This includes integration with authentication and error handling.RemoteSwitcherError,LocalSwitcherError) and constructor helpers for clear error reporting when switchers are missing locally or remotely. [1] [2]checkLocalSwitchersto efficiently check for missing switchers in the local snapshot./criteria/switchers_check, including decoding and error mapping. [1] [2]Testing:
client_check_switchers_test.gocovering local and remote validation, error scenarios, and edge cases for the new switcher validation functionality.Workflow and config updates:
v8.0.0tov8.1.0in GitHub Actions workflow files for improved CI scanning. [1] [2].devcontainer/docker-compose.ymlfor configuration simplification.Code cleanup:
errors.go.These changes enhance the robustness of switcher key validation, improve error clarity, and add thorough test coverage for this critical functionality.