feat: changed flush to clean execution history too #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
petruki
added a commit
that referenced
this pull request
Oct 14, 2025
petruki
added a commit
that referenced
this pull request
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the handling of execution history in the
SwitcherBuilderclass and refactors test code to use a constant for the default environment, improving maintainability and consistency. The most significant change is the centralization of thehistoryExecutionmap inSwitcherBuilder, along with updates to test setup and usage patterns.Core library improvements
historyExecutionmap fromSwitcherRequesttoSwitcherBuilder, ensuring execution history is managed at the builder level and simplifying the class hierarchy. Theflush()method now clears both entries and execution history. (src/main/java/com/switcherapi/client/model/SwitcherBuilder.java,src/main/java/com/switcherapi/client/model/SwitcherRequest.java) [1] [2] [3] [4] [5]Test infrastructure modernization
SwitcherThrottleTestto useSwitchersBaseinstead ofSwitchers, updated initialization and reset logic, and removed unnecessary test method annotations for better clarity and reliability. (src/test/java/com/switcherapi/client/SwitcherThrottleTest.java) [1] [2] [3] [4] [5]