Add :copyfrom support and validate unsupported query annotations#33
Add :copyfrom support and validate unsupported query annotations#33
:copyfrom support and validate unsupported query annotations#33Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5ad0f58c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| func fsharpFieldAccessor(argName string, field Field) string { | ||
| return argName + "." + sdk.ToPascalCase(field.Name) |
There was a problem hiding this comment.
Support scalar args in :copyfrom field accessor
For :copyfrom queries with exactly one SQL parameter, buildQueries leaves Arg.Struct nil and the generated function takes seq<primitive>, but fsharpFieldAccessor always emits property access (arg.<Field>). In that case the template generates code like writer.Write(arg.Name) for seq<string>, which does not compile and breaks single-column copy-from generation (including nullable single-column inserts).
Useful? React with 👍 / 👎.
- Add support for `:execlastid` which executes an INSERT then calls `SELECT lastval()` on the same connection - Remove previous error for unsupported `:execlastid` annotation - Update parameter binding to accept configurable indentation for F# code generation - Add test coverage for `:execlastid` generation and unknown command errors - Update READ
No description provided.