Conversation
Member
|
This looks great! Happy to merge when all boxes are ticked :) |
…wup-link-to-fragment attribute
Contributor
Author
|
Looks like it’s ready for a review now. |
Member
|
Released in 1.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for multiple comma-separated fragment selectors in the
data-swup-link-to-fragmentattribute. Previously, only a single selector was supported. Now users can specify multiple selectors where the first matching element will be used for updating the fragment link.This is usefull for modals shown on-top of content which renders another swup fragment (filtered or paginated lists for example).
TODO
data-swup-link-to-fragment.Checks
mainbranchnpm run lint)npm run test)Additional information