oci: Add OCI-SIF docs. General restructure. #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrudg
force-pushed
the
issue183
branch
3 times, most recently
from
bb96334 to
5076f82
Compare
To try and mention OCI-SIF in a sensible manner, I've restructured the OCI page considerably. The intent is that it now gives a reasonable brief overview of what OCI-SIF is, and where that sits.. i.e. Fixes sylabs#183 Not intended to be a full solution for the other related issues, though due to the restructuring / rewriting it will have partly addressed them.
preminger
suggested changes
Sep 5, 2023
Contributor
preminger
left a comment
preminger
left a comment
There was a problem hiding this comment.
See below - plus one additional tiny thing:
The following text was not added as part of this PR, but it seems like a good opportunity to fix it:
"different ... to ..." is a Britishism; the corresponding Americanism is "different ... from ...". And I can tell you from experience that this is one of those that does trip American readers up... 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To try and mention OCI-SIF in a sensible manner, I've restructured the OCI page considerably.
The intent is that it now gives a reasonable brief overview of what OCI-SIF is, and where that sits.., i.e.:
Fixes #183
Not intended to be a full solution for the other related issues, though due to the restructuring / rewriting it will have partly addressed them.