0.5.5: lower stale-prior threshold from 10s to 1s#24
Merged
Conversation
The 10s window from v0.5.3+v0.5.4 was too lenient. Peer process killed and quickly relaunched left lastSeen within the window (old run had sent a CMB seconds before death), so the dedup-reject path killed legitimate redials. 1s threshold tolerates sub-second TCP-retry races during initial handshake; peer restarts (≥1s gap) now recover at the application layer. 150/150 unit tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
The 10s lastSeen-stale window from v0.5.3+v0.5.4 was too lenient. When a peer process is killed and quickly relaunched, its old run had typically sent a CMB seconds before death, so `lastSeen` is still within the 10s window. The dedup logic then rejects the legitimate redial as a same-direction-duplicate, producing `connection ready → immediate disconnect` with no handshake-complete on the dialing side — the exact symptom on iPhone↔Mac-Catalyst MeloMove pair after either side rebuilds.
Lowered to a hardcoded 1s threshold. Sub-second TCP-retry races during initial handshake still keep prior; peer restarts with ≥1s gap recover at the application layer instead of waiting on OS keepalive (~100s).
150/150 tests pass.
🤖 Generated with Claude Code