Skip to content

feat: extract c_vector assembly and add to NetCDF export#75

Merged
HopeBestWorld merged 1 commit intomainfrom
c-vector
Mar 25, 2026
Merged

feat: extract c_vector assembly and add to NetCDF export#75
HopeBestWorld merged 1 commit intomainfrom
c-vector

Conversation

@HopeBestWorld
Copy link
Copy Markdown
Collaborator

  • Refactored MEEMEngine to use a dedicated assemble_c_vector helper method, abstracting the nested coefficient logic out of the main loop.
  • Updated compute_hydrodynamic_coefficients to append the calculated c_vector to the mode results dictionary.
  • Modified run_and_store_results to initialize, capture, and pass a full_c_vector batch array to the storage layer.
  • Updated Results.store_hydrodynamic_coefficients in results.py to accept the c_vector and store it in the xarray Dataset (automatically handled by existing complex-split logic for NetCDF exports).

- Refactored MEEMEngine to use a dedicated assemble_c_vector helper
  method, abstracting the nested coefficient logic out of the main loop.
- Updated compute_hydrodynamic_coefficients to append the calculated
  c_vector to the mode results dictionary.
- Modified run_and_store_results to initialize, capture, and pass a
full_c_vector batch array to the storage layer.
- Updated Results.store_hydrodynamic_coefficients in results.py to
  accept the c_vector and store it in the xarray Dataset (automatically
  handled by existing complex-split logic for NetCDF exports).
@HopeBestWorld HopeBestWorld merged commit fb0bb34 into main Mar 25, 2026
6 checks passed
@HopeBestWorld HopeBestWorld deleted the c-vector branch March 25, 2026 04:31
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.40183%. Comparing base (3341c60) to head (aa5db42).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main         #75         +/-   ##
===================================================
+ Coverage   98.38833%   98.40183%   +0.01351%     
===================================================
  Files             11          11                 
  Lines           1303        1314         +11     
===================================================
+ Hits            1282        1293         +11     
  Misses            21          21                 
Flag Coverage Δ
unit 98.40183% <100.00000%> (+0.01351%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant