feat: extract c_vector assembly and add to NetCDF export#75
Merged
HopeBestWorld merged 1 commit intomainfrom Mar 25, 2026
Merged
feat: extract c_vector assembly and add to NetCDF export#75HopeBestWorld merged 1 commit intomainfrom
HopeBestWorld merged 1 commit intomainfrom
Conversation
Collaborator
HopeBestWorld
commented
Mar 25, 2026
- Refactored MEEMEngine to use a dedicated assemble_c_vector helper method, abstracting the nested coefficient logic out of the main loop.
- Updated compute_hydrodynamic_coefficients to append the calculated c_vector to the mode results dictionary.
- Modified run_and_store_results to initialize, capture, and pass a full_c_vector batch array to the storage layer.
- Updated Results.store_hydrodynamic_coefficients in results.py to accept the c_vector and store it in the xarray Dataset (automatically handled by existing complex-split logic for NetCDF exports).
- Refactored MEEMEngine to use a dedicated assemble_c_vector helper method, abstracting the nested coefficient logic out of the main loop. - Updated compute_hydrodynamic_coefficients to append the calculated c_vector to the mode results dictionary. - Modified run_and_store_results to initialize, capture, and pass a full_c_vector batch array to the storage layer. - Updated Results.store_hydrodynamic_coefficients in results.py to accept the c_vector and store it in the xarray Dataset (automatically handled by existing complex-split logic for NetCDF exports).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
===================================================
+ Coverage 98.38833% 98.40183% +0.01351%
===================================================
Files 11 11
Lines 1303 1314 +11
===================================================
+ Hits 1282 1293 +11
Misses 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.