Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.0.4 #1581

Merged
merged 31 commits into from
Jul 8, 2021
Merged

Release v1.0.4 #1581

merged 31 commits into from
Jul 8, 2021

Conversation

bassemmagdy
Copy link
Contributor

Added

  • Added mosaic envelop icon and tooltips for transaction list
  • Added the possibility to check if aggregate transaction has to be signed without opening details
  • Added skip button for mnemonic confirmation on Testnet
  • Added minRemoval and minApproval values on the multisig tree

Changed

  • Copy paste password on profile creation now is not accepted
  • Custom nodes now are assigned to a profile and not removed when switching between networks
  • Changed icon size and positions to make them more consistent
  • Changed QR code image for failure when transactions are too big

Fixed

  • Fix input focus error on FormProfileUnlock
  • Fixed amount validation when sending big quantities
  • Fix encrypted message console error
  • Fixed fee multiplier for offline transaction mode
  • Fix transaction signing icon doesn't show up immediately after signing
  • Fixed ledger translation
  • Fixed account restrictions modal UI
  • Fix harvesting not showing 25% of the beneficiary
  • Fix decimal separator causing problems between locales
  • Fixed copy paste password input
  • Fix harvesting node not showing while activated on different devices
  • Fixed Scanning a QR Code for a Transfer Transaction without Mosaics breaks the Wallet
  • Fix harvesting node not visible if connected to it
  • Removed redundant space in mosaics amount when imported from QR code with the prepared invoice
  • Fixed profile creation in Ledger caused some crashes
  • Fixed error covering import QR code button in offline mode
  • Fixed harvesting screen tabs not aligned and scrollable
  • Ordered fee selection option
  • Removed fee selector redundant caption for min fee multipliers
  • Fixed partial aggregate transactions disappearing when signing
  • Fixed unable to add new node when all nodes are offline
  • Fixed users could try changing symbol.xym properties
  • Fixed harvesting screen not showing correct status for node operators
  • Fixed when importing QR code for a transaction slow fee changed to slowest
  • Fixed the balance was sometimes not shown on wallet selection page
  • Fixed some form items were not aligned
  • Fixed duration of Namespace rental adds 1 day.
  • Fixed bug when entering amounts in offline mode.
  • Fixed when put max value transaction details are not presented
  • Other UI fixes
  • Other translations and wording fixes

rg911 and others added 29 commits May 17, 2021 12:49
@rg911
Merge pull request #1497 from nemgrouplimited/main
0ebe061 
Merge pull request #1495 from nemgrouplimited/integration
@bassemmagdy
fix harvesting problem when activated on different device (#1436)
4021075 
* fix #1431 #1332

* fix harvesting showing wrong status on fresh accounts
@bassemmagdy
Revert "fix harvesting problem when activated on different device (#1436
29ec0af 
)" (#1527)

This reverts commit 4021075.
@bassemmagdy @rg911 @segfaultxavi
Merge main changes (#1545)
c56910d 
* Improve transaction previews (#1505)

* improve transactiondashboard preview #1190

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* update mosaic list tooltip

Co-authored-by: Steven Liu <xian.f.liu@gmail.com>
Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* Revert "Improve transaction previews (#1505)" (#1539)

This reverts commit 670fcad.

Co-authored-by: Steven Liu <xian.f.liu@gmail.com>
Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>
@bassemmagdy @myxmaster
@AnthonyLaw @OlegLialin @segfaultxavi
Sprint 1 fixes (#1542)
38a7591 
* fix scrolling on aggregate tx page (#1352)

* fix: balance aligment UI issue. (#1521)

* checks if bonded is signed in transactions history list  (#1522)

* checks if bonded is signed in transactions history list #1488

* Update src/language/zh-CN.json

Co-authored-by: Anthony Law <yc-law1015@hotmail.com>

* refactor needsCosignature check to async

Co-authored-by: Anthony Law <yc-law1015@hotmail.com>

* bugfix/Scanning a qr with no mosaics breaks the wallet (#1518)

* fix Scanning a QR Code for a Transfer Transaction without Mosaics breaks the Wallet #1503

* fix fees list consistency

* fix mosaic amount sometimes not shown while importing mnemonic (#1517)

* fix #1514

* add loader on fetching accounts balances

* remove setTimeout

* enhance profile creation phrasing (#1512)

* Rephrased profile creation

* fix #930

Co-authored-by: olegliallin <olegliallin@gmail.com>

* fix wrong expired message for mosaics with 0 balance #1468 (#1511)

* fix setting popup styles (#1509)

* fix setting popup styles #1448

* fix redundant scrollbar

* fix fees not always displayed

* fix scrollbar issue

* update settings modal

* Gh1431 harvesting fix (#1528)

* fix #1431 #1332

* fix harvesting showing wrong status on fresh accounts

* fix #1264 (#1480)

* fix error message while creating new profile on ledger (#1508)

* fix error message while creating new profile on ledger #1483

* remove logs

* fix icons inconsistency (#1507)

* fix iconsconsistency #1446

* update multisigForm add button styles

* fix button style

* fix #1445

* fix #1472 (#1506)

* Fix harvesting tabs alignment  (#1500)

* sort fees selector options #1430

* fix tab alignments in harvesting page #1441

* fixes #1491

* update fees selector

* fix amount field bug while importing transaction from a qr-code (#1485)

* fix #1459 (#1460)

* fix date not showing properly for aggregate transactions #1459

* fix transfer transaction date diplay

* update hashlock date representation

* Fix log in/log out spelling (#1450)

"Log in/out" is a verb, whereas "login/logout" are nouns.

* fix #1076 #1416 (#1449)

* fix #1076 #1416

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* update settings modal to select networkTab when opened from node selector

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* fix #873 (#1458)

* fix #873

* update namespaceTableService

* fix expiry checkbox

* fix validation for namespace name #1376 (#1452)

* fix validation for namespace name #1376

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* add comment to update regex when rest is fixed

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* fix: namespace expired logic error. (#1525)

* display delegate harvesting message properly (#1513)

* fix connected nodes doesn't show up in node selector harvesting (#1502)

* fix connected nodes doesn't show up in node selector harvesting #1106

* update peerNodes

* fix un-signed transactions disappear after signing another partial #1487 (#1499)

* fix the unablity to add node when all default nodes offline #1236 (#1489)

* fix #1432 (#1439)

* fix Harvesting when importing harvesting private key from node operator #1432

* fix #1432

* Update NetworkNodeSelectorTs.ts

* fix translation in login page

* Gh1090 improve transaction previews (#1540)

* improve transactiondashboard preview #1190

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* update mosaic list tooltip

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* Revert "Gh1090 improve transaction previews (#1540)" (#1543)

This reverts commit 12a0d3d.

* fix #1432

Co-authored-by: myxmaster <77545287+myxmaster@users.noreply.github.com>
Co-authored-by: Anthony Law <yc-law1015@hotmail.com>
Co-authored-by: olegliallin <olegliallin@gmail.com>
Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>
@AdriaCarrera
Fix account restrictions UI (#1556)
7d0c48c
@AdriaCarrera
Fix harvesting not showing 25% of the beneficiary (#1555)
fa8a9b5
@AnthonyLaw @OlegMakarenko
Added mosaic envelop icon and tooltips for transaction list. (#1549)
29d52f6 
* feat: add new icon image.

* feat: add icon and tooltip feature for mosaic and message.

* fix: adjust css for tooltips.

* fix: wrong format tooltips mosaics to relative amount.

* Update en-US.json

Co-authored-by: OlegMakarenko <33131259+OlegMakarenko@users.noreply.github.com>
@AnthonyLaw
fix: divisibility problem for offline mode (#1538)
9e74fc7 
* fix: divisibility problem for offline mode

* test: add unit test
@AnthonyLaw
Fix reconnect issue. (#1536)
5e43ba2 
* fix: reconnect able click on the home page.

* test: add unit test
@AdriaCarrera
Changed english and japanese wordings for password error (#1535)
aefd68a
@AdriaCarrera
Multisig tree information fix (#1533)
ad8246b 
* Multisig tree information fix

* Linting
@AdriaCarrera
QR Code show failure (#1534)
5c54704
@bassemmagdy
fix Acount metadata not signable if target account multisig #1136 (#1482
2419a7b 
)
@bassemmagdy
fix ledger translation #930 (#1559)
e41039d
@bassemmagdy @AnthonyLaw
fix harvesting node not showing while activated on different devices (#…
a672d33 
…1548)

* fix harvesting node not showing while activated on different devices

* fix: selected node will appear in harvesting list.

* fix: when change profile, the harvest stat will be refresh.

* fix: add node operate check, if that is not nodeKey exist.

Co-authored-by: AnthonyLaw <yc-law1015@hotmail.com>
@bassemmagdy
fix trasaction signing icon doesn't show immediately after signing #1488
c865cc6 
 #930 (#1560)
@bassemmagdy
Fix password copy paste (#1550)
ff21609 
* update password fields to reject copy and paste actions #1167

* Linting

* remove non-used prop
@bassemmagdy @AdriaCarrera
fix local issue in amount field (#1551)
6b0fe14 
* fix local issue in amount field #1531

* Moved decimalSeparator into utils and applied to appConfig

Co-authored-by: AdriaCarrera <adria.cm95@gmail.com>
@AnthonyLaw
fix: fee multiplier for offline tx (#1565)
e49c0b9
@AnthonyLaw @myxmaster
Add max amount validator. (#1524)
d8819a6 
* fix scrolling on aggregate tx page (#1352)

* fix: balance aligment UI issue. (#1521)

* Fix: add validator to check mosaic max amount.

* Fix: add maxAmount validator into rules

* test: add maxAmount on test.

* fix: add max amount error mesage on language.

* refactor: removed hardcore value and rename validator name.

Co-authored-by: myxmaster <77545287+myxmaster@users.noreply.github.com>
@AnthonyLaw
fix: encrypt console error (#1567)
85ef26f
@AdriaCarrera
Fix node storage indexed by profileName (#1554)
6df9a4c
@bassemmagdy
fix #1167 (#1570)
a506545
@AnthonyLaw
Fix CR (#1569)
37aaaf8 
* fix: display "Encrypted message" if message os encrypted.

* fix: check on locale decimal separator before comparing value.

* fix: dynamic check in max relative amount with divisibility

* test: add max relative amout in unit test and lint fix
@fboucquez
Docker release image on tag (#1396)
b1502f2
@fboucquez
Added proper stages to travis
352a78f
@AnthonyLaw
fix: input focus console error (#1574)
00288bb
@fboucquez
Update .travis.yml (#1573)
b15d014
bassemmagdy and others added 2 commits July 6, 2021 10:43
@bassemmagdy @rg911 @segfaultxavi
aligning commits with main branch (#1579)
7f5e011 
* Improve transaction previews (#1505)

* improve transactiondashboard preview #1190

* Update src/language/en-US.json

Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* update mosaic list tooltip

Co-authored-by: Steven Liu <xian.f.liu@gmail.com>
Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>

* Revert "Improve transaction previews (#1505)" (#1539)

This reverts commit 670fcad.

Co-authored-by: Steven Liu <xian.f.liu@gmail.com>
Co-authored-by: Xavi Artigas <xavierartigas@yahoo.es>
@bassemmagdy
update change log for v1.0.4 (#1580)
2b1dd20 
* update changelog for release

* Update CHANGELOG.md
@bassemmagdy bassemmagdy merged commit a4f307e into main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdriaCarrera AdriaCarrera AdriaCarrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bassemmagdy @AdriaCarrera @rg911 @AnthonyLaw @fboucquez