Implementation proposal for task/g53 : Fees

[evias]

Implementation proposal for Fees features including:

Added

• Renamed fee transaction classes fields to maxFee (Fees #53 )
• Added maxFee optional field to create() factories. (Fees #53 )
• Added Transaction.size getter method to return base transaction byte size (Fees #53 )
  • The calculation currently assumes signature and signer fields to be set.
• Added size getter overload using Transaction.size base getter in all transaction type classes (Fees #53 )
  • Each transaction type defines its own type specific data byte size.
• Added TransactionHttp.getTransactionEffectiveFee(transactionHash|transactionId) (Fees #53 )

Fixed

• Fixed BlockInfo model for missing fields (BlockInfo class upgrade for cow blocks #100 )

[coveralls]

Pull Request Test Coverage Report for Build 264

• 127 of 134 (94.78%) changed or added relevant lines in 21 files are covered.
• 10 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.7%) to 72.515%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/infrastructure/transaction/CreateTransactionFromDTO.ts	4	5	80.0%
src/model/transaction/AliasTransaction.ts	0	2	0.0%
src/infrastructure/TransactionHttp.ts	3	7	42.86%

Files with Coverage Reduction	New Missed Lines	%
src/model/namespace/NamespaceId.ts	2	72.73%
src/service/NamespaceService.ts	8	21.43%

Totals
Change from base Build 260:	0.7%
Covered Lines:	1144
Relevant Lines:	1431

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 264

• 127 of 134 (94.78%) changed or added relevant lines in 21 files are covered.
• 10 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.7%) to 72.515%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/infrastructure/transaction/CreateTransactionFromDTO.ts	4	5	80.0%
src/model/transaction/AliasTransaction.ts	0	2	0.0%
src/infrastructure/TransactionHttp.ts	3	7	42.86%

Files with Coverage Reduction	New Missed Lines	%
src/model/namespace/NamespaceId.ts	2	72.73%
src/service/NamespaceService.ts	8	21.43%

Totals
Change from base Build 260:	0.7%
Covered Lines:	1144
Relevant Lines:	1431

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 296

• 130 of 148 (87.84%) changed or added relevant lines in 22 files are covered.
• 10 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.05%) to 75.057%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/model/transaction/AliasTransaction.ts	0	2	0.0%
src/infrastructure/TransactionHttp.ts	3	9	33.33%
src/infrastructure/transaction/CreateTransactionFromDTO.ts	6	16	37.5%

Files with Coverage Reduction	New Missed Lines	%
src/model/namespace/NamespaceId.ts	2	76.0%
src/service/NamespaceService.ts	8	21.43%

Totals
Change from base Build 280:	-0.05%
Covered Lines:	1387
Relevant Lines:	1696

---

💛 - Coveralls

[rg911]

👍

[evias]

Merge stalled - Problem with BlockInfo upgrade with beneficiaryPublicKey field, breaking most of the transaction listeners.

Awaiting more details.