Skip to content

Task/g4 check act has all cosignatories #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Apr 10, 2019
Merged

Task/g4 check act has all cosignatories #106

merged 38 commits into from
Apr 10, 2019

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Apr 1, 2019

Issue: #4

  • Fixed bugs in Transaction Mapping - createFromPayload
  • Added new service for AggreateTransaction - isComplete with multip levels multisig account support

rg911 added 4 commits March 18, 2019 10:05
@rg911
Added symbol#4 check if an aggregate complete transaction has all cos…
486d378 
…ignatories
@rg911
Added symbol#4 check if an aggregate complete transaction has all cos…
7d1d2fb 
…ignatories
@rg911
symbol#4
41b0b45 
1. Addes service for Aggregated Transaction - isComplete
2. Fixed couple of bugs in TransactionMappings
@rg911
Merge branch 'task/g4_check_act_has_all_sosignatories' of github.com:…
e50f160 
…rg911/nem2-sdk-typescript-javascript into task/g4_check_act_has_all_sosignatories
@rg911 rg911 requested review from dgarcia360 and evias April 1, 2019 19:43
rg911 added 3 commits April 1, 2019 20:43
@rg911
Added symbol#4 check if an aggregate complete transaction has all cos…
319ba1d 
…ignatories
@rg911
symbol#4
b740dee 
1. Addes service for Aggregated Transaction - isComplete
2. Fixed couple of bugs in TransactionMappings
@rg911
Merge branch 'task/g4_check_act_has_all_sosignatories' of github.com:…
93e4ad6 
…rg911/nem2-sdk-typescript-javascript into task/g4_check_act_has_all_sosignatories
@coveralls
Copy link

coveralls commented Apr 1, 2019

Pull Request Test Coverage Report for Build 276

  • 35 of 35 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.7%) to 75.691%
Totals Coverage Status
Change from base Build 275: 1.7%
Covered Lines: 1333
Relevant Lines: 1615
💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 1, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 308

  • 46 of 46 (100.0%) changed or added relevant lines in 2 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+2.5%) to 79.122%
Files with Coverage Reduction New Missed Lines %
src/infrastructure/transaction/CreateTransactionFromDTO.ts 1 75.17%
src/model/namespace/NamespaceId.ts 2 80.0%
src/service/NamespaceService.ts 8 21.43%
Totals Coverage Status
Change from base Build 305: 2.5%
Covered Lines: 1491
Relevant Lines: 1770
💛 - Coveralls

rg911 added 5 commits April 1, 2019 21:25
@rg911
Updated license year
08c8ce3
@rg911
Added symbol#4 check if an aggregate complete transaction has all cos…
f32982d 
…ignatories
@rg911
symbol#4
41eb60e 
1. Addes service for Aggregated Transaction - isComplete
2. Fixed couple of bugs in TransactionMappings
@rg911
Updated license year
478c8a4
@rg911
Merge branch 'task/g4_check_act_has_all_sosignatories' of github.com:…
3b470d1 
…rg911/nem2-sdk-typescript-javascript into task/g4_check_act_has_all_sosignatories
evias
evias suggested changes Apr 2, 2019
View reviewed changes
@rg911
Added check in validate cosignatories for
3d1d1f6 
modify multisig account (removal)
@dgarcia360 dgarcia360 changed the title Task/g4 check act has all sosignatories Task/g4 check act has all cosignatories Apr 4, 2019
rg911
rg911 commented Apr 5, 2019
View reviewed changes
Copy link
Contributor Author

@rg911 rg911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added checks on minRemoval if the inner transaction type is ModifyMultisigAccountTransaction (with removal modifications)

evias
evias suggested changes Apr 10, 2019
View reviewed changes
rg911 added 5 commits April 10, 2019 15:13
@rg911
renamed AggregatedTransactionService
eb2e12f
@rg911
symbol#4
5776201 
1. Addes service for Aggregated Transaction - isComplete
2. Fixed couple of bugs in TransactionMappings
@rg911
Updated license year
90e805f
@rg911
Added check in validate cosignatories for
c33a4c3 
modify multisig account (removal)
@rg911
Fixed bug in create transaction from payload
9c4ae75
rg911 added 16 commits April 10, 2019 15:15
@rg911
Added more test cases and fixed a few bugs
ffed0a7
@rg911
renamed AggregatedTransactionService
461f34b
@rg911
Merge branch 'task/g4_check_act_has_all_sosignatories' of github.com:…
91931f0 
…rg911/nem2-sdk-typescript-javascript into task/g4_check_act_has_all_sosignatories
@rg911
symbol#4
f944d3b 
1. Addes service for Aggregated Transaction - isComplete
2. Fixed couple of bugs in TransactionMappings
@rg911
Updated license year
516b5e6
@rg911
Added check in validate cosignatories for
fb47164 
modify multisig account (removal)
@rg911
Fixed bug in create transaction from payload
daeb1cb
@rg911
Added more test cases and fixed a few bugs
3da7cf7
@rg911
renamed AggregatedTransactionService
1cef7f8
@rg911
symbol#4
18a5f2a 
1. Addes service for Aggregated Transaction - isComplete
2. Fixed couple of bugs in TransactionMappings
@rg911
Updated license year
df799f6
@rg911
Added check in validate cosignatories for
6a01621 
modify multisig account (removal)
@rg911
Added more test cases and fixed a few bugs
e6136e0
@rg911
renamed AggregatedTransactionService
9754295
@rg911
Merge branch 'task/g4_check_act_has_all_sosignatories' of github.com:…
a28caf5 
…rg911/nem2-sdk-typescript-javascript into task/g4_check_act_has_all_sosignatories
@rg911
Fixed issue on createTransactionFromJson
85439ba 
Changed default validation result value to false;
@rg911 rg911 deleted the task/g4_check_act_has_all_sosignatories branch April 10, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgarcia360 dgarcia360 Awaiting requested review from dgarcia360

1 more reviewer

@evias evias evias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rg911 @coveralls @evias