Skip to content

Fixed #132 bugs in encrypt / decrypt messages #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2019
Merged

Fixed #132 bugs in encrypt / decrypt messages #133

merged 3 commits into from
May 2, 2019

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Apr 30, 2019 •
edited
Loading

Bug fixed Issue: #132

This bug was due to wrong hash algorithm (keccak256) used in shareKey derive method on encrypt / decrypt method. Now fixed.

@rg911 rg911 requested a review from evias April 30, 2019 10:33
@coveralls
Copy link

coveralls commented Apr 30, 2019

Pull Request Test Coverage Report for Build 361

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 79.188%
Totals Coverage Status
Change from base Build 352: -0.02%
Covered Lines: 1515
Relevant Lines: 1813
💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 30, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 374

  • 17 of 20 (85.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 79.554%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/infrastructure/transaction/CreateTransactionFromPayload.ts 6 9 66.67%
Totals Coverage Status
Change from base Build 373: -0.1%
Covered Lines: 1513
Relevant Lines: 1784
💛 - Coveralls

@rg911
Fixed create transaction from payload / dto always
5ed485e 
return plain message bug.

Fixed bug on EncryptedMessage.createFromPayload.

Updated unit tests
@rg911 rg911 deleted the task/g132_encrypted_message branch June 4, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@evias evias evias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rg911 @coveralls @evias