-
Notifications
You must be signed in to change notification settings - Fork 57
Task/g138 fix e2e test #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved e2e conf out put ts compile Upgraded typescript version to 2.9.2 Fixed lint issues in listner.ts Fixed all vulnerabilities in npm packages.
fixed a few http handler bugs
Removed ModifyMultiSigAccount linstener test as the channle doesn't exit
Contributor
|
branch presents build problems due to open nemtech/nem2-library-js#39 PR. |
evias
approved these changes
May 16, 2019
Pull Request Test Coverage Report for Build 392
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #138
Dependant: Nem2-Lib PR 39
This PR:
network.confinstead, so it can be modified at runtime.nullmessage response.Op_Hash_160algorithm. Padded trailing0sto matchSHA3_256hash length. (See changes in corresponding Nem2-Lib PR)On going concerns:
nemesis_addresses. Theses addresses may change if local server wiped outmodifyMultisigAccountWebsocket channel does not exists on bootstrap_server.ModifyMultisigAccountTransaction