Skip to content

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented May 10, 2019

Issue: #138

Dependant: Nem2-Lib PR 39

This PR:

  • Fixed all e2e tests
  • Removed e2e pre-compiled configuration file. Use JSON config network.conf instead, so it can be modified at runtime.
  • Fixed bug in CreateTranactionFromDto handling null message response.
  • Fixed HashlockTranasction cannot be created using Op_Hash_160 algorithm. Padded trailing 0s to match SHA3_256 hash length. (See changes in corresponding Nem2-Lib PR)
  • Fixed AccountLinkTransaction transaction size too big bug. (See changes in corresponding Nem2-Lib PR)
  • Fixed AccountProperty bugs

On going concerns:

  1. For local testing, we have to use bootstrap_server nemesis_addresses. Theses addresses may change if local server wiped out
  2. modifyMultisigAccount Websocket channel does not exists on bootstrap_server.
  3. Cannot test AccountLinkTransaction as it needs harvesting account.
  4. Some test will fail if re-run multiple times. E.g. ModifyMultisigAccountTransaction

rg911 added 5 commits May 7, 2019 10:11
Moved e2e conf out put ts compile
Upgraded typescript version to 2.9.2
Fixed lint issues in listner.ts
Fixed all vulnerabilities in npm packages.
fixed a few http handler bugs
@evias
Copy link
Contributor

evias commented May 13, 2019

branch presents build problems due to open nemtech/nem2-library-js#39 PR.

@coveralls
Copy link

coveralls commented May 16, 2019

Pull Request Test Coverage Report for Build 392

  • 20 of 33 (60.61%) changed or added relevant lines in 7 files are covered.
  • 28 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 79.05%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/infrastructure/Listener.ts 0 1 0.0%
src/infrastructure/AccountHttp.ts 1 5 20.0%
src/core/utils/DtoMapping.ts 7 15 46.67%
Files with Coverage Reduction New Missed Lines %
src/infrastructure/AccountHttp.ts 28 28.0%
Totals Coverage Status
Change from base Build 375: 0.01%
Covered Lines: 1532
Relevant Lines: 1824

💛 - Coveralls

@rg911 rg911 deleted the task/g138_fix_e2e_test branch June 4, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants