Skip to content

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Jun 11, 2019

Issue: #94

Merged all crypto implementations into the SDK

Dragon Milestone / 2: https://github.com/nemtech/nem2-sdk-typescript-javascript/milestone/2

** Note: This PR includes Encoders merge changes in #168

rg911 added 2 commits June 11, 2019 19:41
Merged encoders from Lib into SDK
Merged crypto implementation
@rg911 rg911 closed this Jun 11, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 453

  • 1224 of 1293 (94.66%) changed or added relevant lines in 34 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.8%) to 83.577%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/crypto/KeyPair.ts 16 17 94.12%
src/core/format/RawUInt64.ts 33 34 97.06%
src/core/crypto/SHA3Hasher.ts 15 18 83.33%
src/core/format/Convert.ts 57 63 90.48%
src/core/format/RawAddress.ts 37 44 84.09%
src/core/crypto/Utilities.ts 107 120 89.17%
src/core/crypto/nacl_catapult.ts 675 688 98.11%
src/core/crypto/Crypto.ts 77 102 75.49%
Totals Coverage Status
Change from base Build 442: 4.8%
Covered Lines: 2882
Relevant Lines: 3289

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 11, 2019

Pull Request Test Coverage Report for Build 464

  • 1252 of 1293 (96.83%) changed or added relevant lines in 34 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+6.2%) to 84.944%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/format/RawUInt64.ts 33 34 97.06%
src/core/crypto/Crypto.ts 97 102 95.1%
src/core/format/Convert.ts 57 63 90.48%
src/core/format/RawAddress.ts 37 44 84.09%
src/core/crypto/Utilities.ts 110 120 91.67%
src/core/crypto/nacl_catapult.ts 676 688 98.26%
Totals Coverage Status
Change from base Build 442: 6.2%
Covered Lines: 2910
Relevant Lines: 3289

💛 - Coveralls

@rg911 rg911 reopened this Jun 12, 2019
@rg911 rg911 requested a review from evias June 12, 2019 08:14
@rg911 rg911 changed the title Merge crypto implementation into SDK Issue: #94 Merge crypto implementation into SDK Jun 12, 2019
@rg911 rg911 changed the title Issue: #94 Merge crypto implementation into SDK 2 - Issue: #94 Merge crypto implementation into SDK Jun 12, 2019
Grégory Saive and others added 4 commits June 14, 2019 15:38
1 - Issue symbol#93 Merged encoders from Lib into SDK
Merged crypto implementation
…11/nem2-sdk-typescript-javascript into task/g94_merge_crypto_implementation
@rg911 rg911 deleted the task/g94_merge_crypto_implementation branch July 8, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants