Skip to content

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Jun 12, 2019

Issue #95
Merged transaction Builders from library
Applied merged builders to transaction models.

** CI build fails as this PR is dependant on below previous PRs:

rg911 added 6 commits June 11, 2019 19:41
Merged encoders from Lib into SDK
Merged crypto implementation
Merged existing buffers and schemas
Merged transaction builder from Library
@rg911 rg911 requested a review from evias June 12, 2019 09:55
@rg911 rg911 changed the title Issue: #95 Merge library transaction builder 4 - Issue: #95 Merge library transaction builder Jun 12, 2019
rg911 and others added 14 commits June 12, 2019 22:47
1 - Issue symbol#93 Merged encoders from Lib into SDK
Merged crypto implementation
…11/nem2-sdk-typescript-javascript into task/g94_merge_crypto_implementation
…entation

2 - Issue: symbol#94 Merge crypto implementation into SDK
Merged existing buffers and schemas
…g911/nem2-sdk-typescript-javascript into task/g170_merge_existing_buffer_schema
…fer_schema

3 - Issue symbol#170 Merged existing buffers and schemas
Merged transaction builder from Library
…om:rg911/nem2-sdk-typescript-javascript into task/g95_merge_library_transaction_builder
@coveralls
Copy link

coveralls commented Jun 14, 2019

Pull Request Test Coverage Report for Build 469

  • 3763 of 4823 (78.02%) changed or added relevant lines in 95 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-7.5%) to 71.297%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/format/RawUInt64.ts 33 34 97.06%
src/infrastructure/transaction/NamespaceMosaicIdGenerator.ts 15 16 93.75%
src/core/format/RawAddress.ts 42 44 95.45%
src/infrastructure/builders/AccountLinkTransaction.ts 42 44 95.45%
src/infrastructure/builders/AccountPropertiesAddressTransaction.ts 50 52 96.15%
src/infrastructure/builders/AccountPropertiesEntityTypeTransaction.ts 48 50 96.0%
src/infrastructure/builders/AccountPropertiesMosaicTransaction.ts 49 51 96.08%
src/infrastructure/builders/AddressAliasTransaction.ts 46 48 95.83%
src/infrastructure/builders/MosaicAliasTransaction.ts 45 47 95.74%
src/infrastructure/builders/MosaicSupplyChangeTransaction.ts 45 47 95.74%
Totals Coverage Status
Change from base Build 442: -7.5%
Covered Lines: 5390
Relevant Lines: 6788

💛 - Coveralls

@rg911 rg911 deleted the task/g95_merge_library_transaction_builder branch July 8, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants