Skip to content

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Sep 18, 2019

  • MosaicProperties removed
  • New MosaicFlags class added
  • Made duration mandatory
  • Fully matching E3 mosaic schema
  • Fixed tests

@coveralls
Copy link

coveralls commented Sep 18, 2019

Pull Request Test Coverage Report for Build 654

  • 17 of 17 (100.0%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.8%) to 66.121%

Files with Coverage Reduction New Missed Lines %
src/infrastructure/MosaicHttp.ts 2 52.5%
Totals Coverage Status
Change from base Build 651: -2.8%
Covered Lines: 9707
Relevant Lines: 13417

💛 - Coveralls

Copy link

@fullcircle23 fullcircle23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@fboucquez fboucquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great, java sdk needs to do the same!

@rg911 rg911 merged commit b6d66f1 into symbol:master Sep 19, 2019
@rg911 rg911 deleted the task/g226_mosaic_property_refactoring branch October 8, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants