Skip to content

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Oct 12, 2019

  • Changed signer param to be optional on toAggregate when adding inner transactions. If not signer in inner transaction not provided, the main Aggregate transaction signer will be delegated.
  • This change ONLY applies on AggregateComplete transaction
  • Added validation if no signer (inner tx) provided in AggregateBond transaction
  • Added tests

@rg911
Copy link
Contributor Author

rg911 commented Oct 12, 2019

@dgarcia360 @evias

@coveralls
Copy link

coveralls commented Oct 12, 2019

Pull Request Test Coverage Report for Build 753

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 748: 0.0%
Covered Lines: 10
Relevant Lines: 10

💛 - Coveralls

@rg911 rg911 merged commit d09b224 into symbol:master Oct 13, 2019
@rg911 rg911 deleted the task/g185_toAggregate_optional_signer branch December 3, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants