Skip to content

JAV-69 Fixed address alias deserialization bug #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Oct 14, 2019
Merged

JAV-69 Fixed address alias deserialization bug #308

merged 1 commit into from Oct 14, 2019

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Oct 14, 2019

Fixed address alias deserialization bug as NamespaceId bytes need to be reversed.

issue: #307

@rg911 rg911 requested review from evias and fboucquez October 14, 2019 18:06
@coveralls
Copy link

coveralls commented Oct 14, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 772

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 770: 0.0%
Covered Lines: 10
Relevant Lines: 10
💛 - Coveralls

@rg911 rg911 changed the title Fixed address alias deserialization bug JAV-69 Fixed address alias deserialization bug Oct 14, 2019
@rg911 rg911 merged commit ee1aa81 into symbol:master Oct 14, 2019
@rg911 rg911 deleted the task/g307_unresolved_address_bug branch December 3, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evias evias Awaiting requested review from evias

1 more reviewer

@fboucquez fboucquez fboucquez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rg911 @coveralls @fboucquez