Skip to content

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Oct 31, 2019

Milestone: Fushicho.1

  • Added Address.isValidAddress for plain address string validation.
  • Added Address filter in transaction status websocket listener channel.
  • Changed MetadataTransactionService return type from Transaction to Union types.
  • Made decodeHex method and EmptyAlias class public.
  • Fixed const network type used in AliasToRecipient method.
  • Fixed SecretLock and SecretProof transaction not using UnresolvedAddress issue.
  • Fixed Size method issues for transactions.
  • Fixed other JSDoc issues.

@coveralls
Copy link

coveralls commented Oct 31, 2019

Pull Request Test Coverage Report for Build 810

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 809: 0.0%
Covered Lines: 10
Relevant Lines: 10

💛 - Coveralls

@rg911 rg911 merged commit c7c8b28 into symbol:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants