Skip to content

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Dec 6, 2019

Added service methods in TransactionService for aggregate bonded transaction announcing

Issue: #352

Rebased from #363

rg911 added 30 commits November 28, 2019 19:50
- Updated aggregate transaction handler with secondary source id
- Updated aggregate transaction handler with secondary source id
…m:NEMStudios/nem2-sdk-typescript-javascript into task/g357_standardize_transaction_service
…MStudios/nem2-sdk-typescript-javascript into task/g352_aggregate_bonded_announcing
@coveralls
Copy link

coveralls commented Dec 6, 2019

Pull Request Test Coverage Report for Build 870

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 857: 0.0%
Covered Lines: 10
Relevant Lines: 10

💛 - Coveralls

@dgarcia360
Copy link
Contributor

Since the PR includes #363 logic, I would wait until the previous PR is merged to review fewer lines of code.

evias
evias previously approved these changes Dec 6, 2019
@rg911 rg911 merged commit ef44e02 into symbol:master Dec 6, 2019
@fboucquez fboucquez deleted the task/g352_aggregate_bonded_announcing branch April 13, 2020 12:25
rg911 added a commit to rg911/symbol-sdk-typescript-javascript that referenced this pull request Jul 21, 2020
- Added optional param in CosignatureTransaction.signWith
rg911 added a commit that referenced this pull request Jul 21, 2020
- Added optional param in CosignatureTransaction.signWith
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants