-
Notifications
You must be signed in to change notification settings - Fork 57
NPM Alpha deployments from master #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rg911
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we need this pre / alpha release regarding continuous delivery. If we automatically release on merging on the master branch (assuming all tested), I would consider just using the actual incremental versions.
|
In a perfect world, I would go with patch releases every master merge. I see some problems now:
In Java, we are using the special In Java, a master merge means |
|
@rg911 I've tested the dependency resolution in npm The user needs to explicitly tell npm when installing that it wants a particular tag or alpha version https://medium.com/@kevinkreuzer/publishing-a-beta-or-alpha-version-to-npm-46035b630dd7 Auto-upgrade only works on the latest released version (x.y.z), without any suffix. So: If you have something like in your package.json
It will bring the artifact number https://www.npmjs.com/package/symbol-openapi-typescript-node-client When we merge this, the user would need to explicitly tell npm that they one a particular alpha version. I don't think an unreleased artifact will seek into anybody that wants a release version Try
only 0.8.5 will be installed |
Improved exception handling when the Observable error is in the code, not the http response.
… not the http response.
| if (error instanceof Error) { | ||
| return error; | ||
| } | ||
| return new Error(error); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment about his change: If we just wrap the exception into a new one Error, the original stack trace is lost. We want the stack trace when something in our code fails, like an NPE when mapping the DTO.
Addresses issue #458. Please read the reason for this PR there.
Once this PR is merged, Travis will start deploying an alpha version to npm every master build (nodejs version 8 builder).
The notation is
symbol-sdk:$version-alpha-$datetimeFor example
symbol-sdk:0.17.2-alpha-202002251427(tag alpha)Note that the alpha version uses the next release version, right now it would be
0.17.2-alpha-xxxx. Once0.17.2is released, the next alpha version would be0.17.3-alpha-xxxxI couldn't find any --pre option in
https://docs.npmjs.com/cli/publish
Also, the --tag doesn't allow redeploy if the version is the same. The travis script generates a new alpha version when executed
Note:
NPM_TOKENneeds to be provided in https://travis-ci.org/nemtech/symbol-sdk-typescript-javascript/settings. I could use my token but my account would be the one publishing. Ideally, we should have a bot npm user.The
alphaversion and tag name can be changed for anything. Maybeprerelease?