Skip to content

Task/g50 account properties #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Mar 7, 2019
Merged

Task/g50 account properties #73

merged 25 commits into from
Mar 7, 2019

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Mar 4, 2019

Added 3 transaction types.

  1. AccountPropertyAddressTransaction
  2. AccountPropertyMosaicTransaction
  3. AccountPropertyEntityTypeTransaction.

Also added getAccountProperties in AccountHttp.

Issue: #50

Steven Liu and others added 14 commits February 28, 2019 15:06
Added symbol#50 Account property and modifications. Initial commit
c26ed38
added property modification transactions
0d4e609
fixed a few bugs on account property transaction
1582774
Added symbol#50 Account property and modifications. Initial commit
b05c8fe
added property modification transactions
bf328f6
fixed a few bugs on account property transaction
f0b5fcf
@rg911
Removed and transaction type enum & sperate account property versions
fb0e64c
@rg911
conflict resoved
84c1f8f
@rg911
Added symbol#50 Account property and modifications. Initial commit
03b2586
@rg911
added property modification transactions
897d305
@rg911
fixed a few bugs on account property transaction
d0e04ad
@rg911
Added symbol#50 Account property and modifications. Initial commit
df41887
@rg911
added property modification transactions
c39a3ca
@rg911
Removed and transaction type enum & sperate account property versions
991bdde
@rg911 rg911 requested review from dgarcia360 and evias March 4, 2019 12:58
evias
evias suggested changes Mar 4, 2019
View reviewed changes
@rg911 rg911 requested a review from evias March 4, 2019 13:40
evias
evias suggested changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@evias evias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @rg911 ! only few more documentation changes and linter issues 👍

@rg911
Copy link
Contributor Author

rg911 commented Mar 7, 2019

all sorted

@coveralls
Copy link

coveralls commented Mar 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 194

  • 91 of 107 (85.05%) changed or added relevant lines in 15 files are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.0%) to 71.394%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model/transaction/AccountPropertyTransaction.ts 13 14 92.86%
src/infrastructure/AccountHttp.ts 1 7 14.29%
src/infrastructure/transaction/CreateTransactionFromDTO.ts 1 10 10.0%
Files with Coverage Reduction New Missed Lines %
src/model/namespace/NamespaceId.ts 2 66.67%
src/infrastructure/AccountHttp.ts 5 28.0%
src/service/NamespaceService.ts 8 21.43%
Totals Coverage Status
Change from base Build 190: 1.0%
Covered Lines: 1004
Relevant Lines: 1292
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgarcia360 dgarcia360 Awaiting requested review from dgarcia360

1 more reviewer

@evias evias evias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rg911 @coveralls @evias