Skip to content

Conversation

@evias
Copy link
Contributor

@evias evias commented Mar 12, 2019

Implementation proposal for issue #55 : Added Alias capability for TransferTransaction.recipient field with Address | NamespaceId type.

  • Includes an update of Listener class to detect signer and recipient fields.
  • Includes an update of TransferTransaction class to add recipientToString() helper.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 211

  • 6 of 10 (60.0%) changed or added relevant lines in 3 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.8%) to 70.989%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model/namespace/MosaicAlias.ts 0 1 0.0%
src/infrastructure/Listener.ts 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
src/model/namespace/NamespaceId.ts 2 66.67%
src/service/NamespaceService.ts 8 21.43%
Totals Coverage Status
Change from base Build 208: -0.8%
Covered Lines: 1011
Relevant Lines: 1302

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 211

  • 6 of 10 (60.0%) changed or added relevant lines in 3 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.8%) to 70.989%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model/namespace/MosaicAlias.ts 0 1 0.0%
src/infrastructure/Listener.ts 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
src/model/namespace/NamespaceId.ts 2 66.67%
src/service/NamespaceService.ts 8 21.43%
Totals Coverage Status
Change from base Build 208: -0.8%
Covered Lines: 1011
Relevant Lines: 1302

💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 12, 2019

Pull Request Test Coverage Report for Build 226

  • 7 of 11 (63.64%) changed or added relevant lines in 4 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.9%) to 70.617%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model/namespace/MosaicAlias.ts 0 1 0.0%
src/infrastructure/Listener.ts 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
src/model/namespace/NamespaceId.ts 2 66.67%
src/service/NamespaceService.ts 8 21.43%
Totals Coverage Status
Change from base Build 215: -0.9%
Covered Lines: 1003
Relevant Lines: 1298

💛 - Coveralls

@rg911 rg911 self-requested a review March 13, 2019 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants