Make Subs and Derivative classes closer to SymPy#128
Closed
ShikharJ wants to merge 3 commits intosymengine:masterfrom
Closed
Make Subs and Derivative classes closer to SymPy#128ShikharJ wants to merge 3 commits intosymengine:masterfrom
ShikharJ wants to merge 3 commits intosymengine:masterfrom
Conversation
ShikharJ
changed the title
Member
Author
|
@isuruf I am not confident that this is how it is supposed to be implemented. Please review and suggest revisions. |
Member
Author
|
Ping @isuruf. |
Member
Author
|
Ping @isuruf. |
isuruf
reviewed
Mar 22, 2017
symengine/lib/symengine_wrapper.pyx
Outdated
| return diff(a.expr, a.variables) | ||
| elif isinstance(a, sympy.Subs): | ||
| return Subs(a.expr, a.variables, a.point) | ||
| return Subs.subs(a.expr, a.variables, a.point) |
Member
There was a problem hiding this comment.
Make this a.expr.subs(a.variables, a.point)
Member
Author
There was a problem hiding this comment.
So, should we first have standalone class of expr and function of subs?
ShikharJ
commented
Mar 22, 2017
| _classes = (symengine.Subs,) | ||
|
|
||
| def __new__(cls, *args): | ||
| return symengine.Subs.subs(*args) |
Member
Author
There was a problem hiding this comment.
@isuruf How should this call be modified, as there isn't any standalone subs function in the wrapper?
Member
|
Replaced by #145 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant: #119