Replaced rcp_static_cast<>()-> with down_cast<>().#1156
Merged
isuruf merged 2 commits intosymengine:masterfrom Jan 8, 2017
Merged
Replaced rcp_static_cast<>()-> with down_cast<>().#1156isuruf merged 2 commits intosymengine:masterfrom
rcp_static_cast<>()-> with down_cast<>().#1156isuruf merged 2 commits intosymengine:masterfrom
Conversation
Member
Author
|
ping @certik |
Contributor
|
Sorry, I need to think about this a bit. The previous way should be safe, but this might not be in all cases. @isuruf if you like it, we can merge it. |
Member
Author
|
@isuruf Could you please take a look at this also? |
Contributor
|
It's fine with me if @isuruf gives this +1. |
ranjithkumar007
pushed a commit
to ranjithkumar007/symengine
that referenced
this pull request
Jan 31, 2017
Replaced `rcp_static_cast<>()->` with `down_cast<>().`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant: #1155