NaN Class by ShikharJ · Pull Request #1178 · symengine/symengine

ShikharJ · 2017-01-20T14:38:21Z

@isuruf The builds seem too be failing even though type_codes.inc has been updated. Please review and suggest improvements.

ShikharJ · 2017-01-22T08:37:14Z

Ping @isuruf.

isuruf · 2017-01-22T14:19:36Z

symengine/type_codes.inc

@@ -1,3 +1,6 @@
+#ifdef NAN
+#undef NAN
+#endif


This could create problems for other software including this header. I'd prefer if the typecode was changed.

isuruf · 2017-01-22T14:20:43Z

symengine/tests/printing/test_printing.cpp

+    RCP<const Basic> a;
+
+    a = Nan;
+    REQUIRE(a->__str__() == "nan");


Just do Nan->__str__() == "nan"

isuruf · 2017-01-22T14:21:11Z

symengine/codegen.h

+    void bvisit(const NaN &x)
+    {
+        std::ostringstream s;
+        s << "NOT_A_NUMBER";


Make this NAN

isuruf · 2017-01-22T14:22:12Z

symengine/constants.h

 extern SYMENGINE_EXPORT RCP<const Infty> ComplexInf;
+
+// Not a Number
+extern SYMENGINE_EXPORT RCP<const NaN> Nan;


Can you change this to just nan?

nan is a builtin as well. Sorry about that. Can you change this back to Nan?

isuruf · 2017-01-22T14:23:13Z

symengine/infinity.cpp

-            throw SymEngineException("Indeterminate Expression: `Infty +- "
-                                     "Infty` encountered. Directions don't "
-                                     "match");
-    } else if (is_unsigned_infinity()) {


This condition is not added below

isuruf · 2017-01-22T14:25:44Z

symengine/nan.cpp

+//! NaN is mathematically not equal to anything else, even NaN itself.
+bool NaN::__eq__(const Basic &o) const
+{
+    return false;


Why this? SymPy gives true for nan == nan

@isuruf This is from SymPy's documentation:

>>> Eq(nan, nan) # mathematical equality False >>> nan == nan # structural equality True

Then we should do the same as __eq__ is structural equality.

isuruf · 2017-01-22T14:28:22Z

symengine/nan.cpp

+
+int NaN::compare(const Basic &o) const
+{
+    if (is_same_type(*this, o))


See

symengine/symengine/infinity.cpp

Lines 68 to 73 in c1cd1ad

int Infty::compare(const Basic &o) const

{

SYMENGINE_ASSERT(is_a<Infty>(o))

const Infty &s = down_cast<const Infty &>(o);

return _direction->compare(*(s.get_direction()));

}

for how to implement this.

ShikharJ · 2017-01-23T14:12:26Z

@isuruf Can you please review this?

isuruf · 2017-01-24T13:20:34Z

symengine/tests/basic/test_arit.cpp

    REQUIRE(eq(*r1, *r2));

+    r1 = div(zero, zero);
+    REQUIRE(r1->__str__() == "nan");


Use eq(*r1, *Nan) here and below

isuruf

Looks good.
Can you resolve conflicts?

isuruf · 2017-01-24T18:28:21Z

symengine/tests/basic/test_infinity.cpp

+    n1 = b->div(*c);
+    REQUIRE(n1->__str__() == "nan");
+    n1 = c->div(*c);
+    REQUIRE(n1->__str__() == "nan");


Use eq(*n1, *Nan)

isuruf · 2017-01-24T18:28:50Z

symengine/nan.h

+    inline bool is_complex() const
+    {
+        return false;
+    }


Add is_exact() here and return false.

ShikharJ · 2017-01-25T09:06:48Z

Ping @isuruf.

ShikharJ · 2017-01-27T05:00:20Z

Ping @isuruf.

isuruf · 2017-01-27T05:08:23Z

Thanks

NaN Class

ShikharJ force-pushed the NaN branch from 14287aa to ac46899 Compare January 21, 2017 21:45

ShikharJ changed the title ~~[WIP] NaN Class~~ NaN Class Jan 21, 2017

ShikharJ force-pushed the NaN branch from ac46899 to 36b5704 Compare January 22, 2017 07:44

isuruf reviewed Jan 22, 2017

View reviewed changes

isuruf requested changes Jan 22, 2017

View reviewed changes

ShikharJ force-pushed the NaN branch 3 times, most recently from 54a30aa to 4efe858 Compare January 23, 2017 13:07

isuruf reviewed Jan 24, 2017

View reviewed changes

ShikharJ force-pushed the NaN branch from 4efe858 to 34d1684 Compare January 24, 2017 14:22

isuruf reviewed Jan 24, 2017

View reviewed changes

ShikharJ force-pushed the NaN branch 3 times, most recently from 08677f7 to 5181bfe Compare January 25, 2017 08:04

ShikharJ added 2 commits January 26, 2017 10:12

Implemented NaN Class

7159c7b

Returned NaN object and Augmented Tests

e183dcf

ShikharJ force-pushed the NaN branch from 5181bfe to e183dcf Compare January 26, 2017 04:48

isuruf merged commit 4f8ce8e into symengine:master Jan 27, 2017

ShikharJ deleted the NaN branch January 27, 2017 05:09

ranjithkumar007 pushed a commit to ranjithkumar007/symengine that referenced this pull request Jan 31, 2017

Merge pull request symengine#1178 from ShikharJ/NaN

37b5aa0

NaN Class

	int Infty::compare(const Basic &o) const
	{
	SYMENGINE_ASSERT(is_a<Infty>(o))
	const Infty &s = down_cast<const Infty &>(o);
	return _direction->compare(*(s.get_direction()));
	}

Conversation

ShikharJ commented Jan 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShikharJ commented Jan 22, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ShikharJ commented Jan 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

isuruf left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ShikharJ commented Jan 25, 2017

Uh oh!

ShikharJ commented Jan 27, 2017

Uh oh!

isuruf commented Jan 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ShikharJ commented Jan 20, 2017 •

edited

Loading

ShikharJ commented Jan 23, 2017 •

edited

Loading