Updated functions.cpp and Added Tests#1180
Merged
isuruf merged 1 commit intosymengine:masterfrom Jan 24, 2017
Merged
Conversation
Member
Author
|
ping @isuruf. |
isuruf
reviewed
Jan 24, 2017
symengine/functions.cpp
Outdated
| if (eq(*arg, *zero)) { | ||
| // Answer is infinity. Yet to be implemented in SymEngine | ||
| throw NotImplementedError("Not Implemented"); | ||
| return infty(0); |
isuruf
reviewed
Jan 24, 2017
| REQUIRE(eq(*r1, *r2)); | ||
|
|
||
| r1 = gamma(minus_one); | ||
| REQUIRE(r1->__str__() == "zoo"); |
Member
There was a problem hiding this comment.
Use eq(*r1, *ComplexInf) instead of comparing using strings.
ShikharJ
force-pushed
the
MiscImprovements
branch
from
52f350b to
8786ccb
Compare
Member
|
@ShikharJ, if it's just one job that needs to be restarted, let me know. I can just restart that job instead of the whole build which has 20 jobs. |
ranjithkumar007
pushed a commit
to ranjithkumar007/symengine
that referenced
this pull request
Jan 31, 2017
Updated functions.cpp and Added Tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.