Merged
Conversation
ShikharJ
force-pushed
the
DirichletEta
branch
from
557864a to
41a3f4d
Compare
isuruf
reviewed
Feb 8, 2017
symengine/functions.h
Outdated
| RCP<const Basic> rewrite_as_zeta() const; | ||
| //! \return Canonicalized zeta | ||
| virtual RCP<const Basic> create(const RCP<const Basic> &arg) const; | ||
| virtual RCP<const Basic> create(const vec_basic &arg) const; |
Member
There was a problem hiding this comment.
This is not needed here as it is defined in OneArgFunction. You can make it visible by adding using OneArgFunction::create
isuruf
reviewed
Feb 8, 2017
symengine/derivative.cpp
Outdated
| return fdiff(self, x); | ||
| } | ||
|
|
||
| static RCP<const Basic> diff(const Dirichlet_eta &self, |
Member
Author
There was a problem hiding this comment.
@isuruf Dirichlet_eta is a OneArgFunction and automatic differentiation via the fdiff routine is enabled by default only for TwoArgFunction.
Member
There was a problem hiding this comment.
Can you try making this OneArgFunction instead of Dirichlet_eta then? If that doesn't work, I'll merge this
ShikharJ
force-pushed
the
DirichletEta
branch
from
41a3f4d to
398dffc
Compare
Member
Author
|
ping @isuruf. |
Member
Author
|
ping @isuruf |
ShikharJ
force-pushed
the
DirichletEta
branch
from
398dffc to
92dd037
Compare
Member
Author
|
ping @isuruf. |
This was referenced Feb 16, 2017
isuruf
added a commit
to isuruf/symengine
that referenced
this pull request
Aug 4, 2018
Improvements over symengine#1120
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant: #814
This PR is a proposed improvement over #1120 by @vishusidana95, which I felt, wasn't along the lines of SymPy's method of execution. As always, please review and suggest improvements.