Conversation
symengine/tests/basic/test_arit.cpp
Outdated
| r3 = add(add(add(r1, r2), integer(1)), real_double(0.2)); | ||
| REQUIRE(is_a<RealDouble>(*r3)); | ||
| REQUIRE(std::abs(down_cast<const RealDouble &>(*r3).i - 1.8) < 1e-12); | ||
| CHECK(is_a<RealDouble>(*r3)); |
There was a problem hiding this comment.
This is not correct. If this check fails the check below will crash. This has to be a REQUIRE
|
I don't know whether this is really necessary, changing 45 files and creating conflicts with all the other PRs. |
|
That's the reason why I mentioned that it is intended as a standing PR, for whenever the need may be (in the future). There had been a number of instances with me, while implementing stuff, where the tests failed but running |
ShikharJ
force-pushed
the
ImproveTests
branch
2 times, most recently
from
c162976 to
1e2df9d
Compare
|
Although this might be a good idea I think due to its many conflicts it will not be worth to resurrect this PR. Can we do some spring cleaning and close? |
|
@rikardn I think we should just close. The codebase has changed significantly since, and there isn't a point in resurrecting this, since the potential advantages aren't much over the disadvantages. |
3 participants
This is a standing PR for now. It can be updated whenever required (in the future).