Allow FosJsRouting dev for Symfony 3 #162
Conversation
Allow FosJsRouting dev for Symfony 3
|
Build is fixed again |
There was a problem hiding this comment.
do we require this or is it some other bundle that requires it? then the @dev should go in there rather than here, i think.
There was a problem hiding this comment.
Testing requires it. @dev isn't needed, only to support Symfony 3 as a Symfony 3 supporting version has not been released.
However, as minimum stability is now set to stable for all CMF repositories, we need to explicitely allow FOSJsRoutingBundle to be installed in dev when needed.
There was a problem hiding this comment.
okay, i see. i hope to release this library really soon - should we do so with this line or should we try to tag a stable version of jsrouting?
There was a problem hiding this comment.
ah its only a dev dependency so no big deal!
There was a problem hiding this comment.
Yeah and it's a dep that's not even used by this library. This is one of the problems of Testing 1.0, eventhough this is a component tested without framework integration, many bundles are still automatically loaded by Testing. For Testing 2.0, I would like to remove all config/required bundles from the component, so each library can make choices themselves.
2 participants
No description provided.