Skip to content

Allow FosJsRouting dev for Symfony 3 #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2015
Merged

Allow FosJsRouting dev for Symfony 3 #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ProviderBasedGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
namespace Symfony\Cmf\Component\Routing;

use Symfony\Component\Routing\Generator\UrlGenerator;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Symfony\Component\Routing\Route as SymfonyRoute;
use Symfony\Component\Routing\RequestContext;
use Symfony\Component\Routing\Exception\RouteNotFoundException;
Expand Down
3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
"symfony-cmf/testing": "^1.3@dev",
"symfony/dependency-injection": "^2.0.5|3.*",
"symfony/config": "^2.2|3.*",
"symfony/event-dispatcher": "^2.1|3.*"
"symfony/event-dispatcher": "^2.1|3.*",
"friendsofsymfony/jsrouting-bundle": "@dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we require this or is it some other bundle that requires it? then the @dev should go in there rather than here, i think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing requires it. @dev isn't needed, only to support Symfony 3 as a Symfony 3 supporting version has not been released.

However, as minimum stability is now set to stable for all CMF repositories, we need to explicitely allow FOSJsRoutingBundle to be installed in dev when needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, i see. i hope to release this library really soon - should we do so with this line or should we try to tag a stable version of jsrouting?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah its only a dev dependency so no big deal!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah and it's a dep that's not even used by this library. This is one of the problems of Testing 1.0, eventhough this is a component tested without framework integration, many bundles are still automatically loaded by Testing. For Testing 2.0, I would like to remove all config/required bundles from the component, so each library can make choices themselves.

},
"suggest": {
"symfony/event-dispatcher": "DynamicRouter can optionally trigger an event at the start of matching. Minimal version (~2.1)"
Expand Down