Improve the class directive code and add Symfony UX support #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Nov 24, 2025
| [$monorepoSubRepository, $classRelativePath] = $classPath->split('\\', 2); | ||
| $classRelativePath = $classRelativePath->replace('\\', '/'); | ||
|
|
||
| $url = \sprintf('https://github.com/symfony/ux/blob/2.x/src/%s/src/%s.php', $monorepoSubRepository, $classRelativePath); |
Member
There was a problem hiding this comment.
Should we hardcode 2.x or should we have a configuration setting to allow linking to the appropriate version based on the version of the UX documentation being rendered ? Or is this meant to be used to reference UX classes from symfony-docs (and so not related to a UX version) ?
Collaborator
Author
There was a problem hiding this comment.
We should allow to configure that version, yes. I opened #199 to handle this. Thanks!
OskarStark
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses @stof's comments about unoptimized code: #196 (comment) and adds support for Symfony UX classes too.