[Deptrac] Add separate layers for Agent bridge tools #1022
Merged
+85
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures Agent bridge tools can only depend on the Agent component and not on each other, preventing cross-bridge dependencies. - Renamed layers to *Component convention - Added individual layers for each Agent bridge tool - SimilaritySearchTool can access StoreComponent and PlatformComponent - Other tools can only access AgentComponent
OskarStark
force-pushed
the
deptrac-agent-bridges
branch
from
43cc8d5 to
389697e
Compare
OskarStark
commented
Nov 29, 2025
| - StoreComponent | ||
| BraveTool: | ||
| - AgentComponent | ||
| - PlatformComponent |
Contributor
Author
There was a problem hiding this comment.
this is needed for example, as the #[With] is used from the Platform component
OskarStark
commented
Nov 29, 2025
| - ./src | ||
| exclude_files: | ||
| - '#.*test.*#' | ||
| - '#.*test.*#i' |
Contributor
Author
There was a problem hiding this comment.
The original pattern #.test.# only matches lowercase "test", but the test files in this codebase are in directories named Tests (capital T), like:
src/agent/src/Bridge/SimilaritySearch/Tests/SimilaritySearchTest.php
Without the i flag, deptrac was analyzing test files and reporting violations for test-only dependencies (like the test using Symfony\AI\Platform\Vector\Vector).
With #.test.#i, it matches both test and Tests, properly excluding all test files from analysis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures Agent bridge tools can only depend on the Agent component and not on each other, preventing cross-bridge dependencies.