Skip to content

[Platform] Rename MessageBag::prepend to actual use-case withSystemMessage #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OskarStark merged 1 commit into from
Dec 7, 2025
Merged

[Platform] Rename MessageBag::prepend to actual use-case withSystemMessage #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/agent/src/InputProcessor/SystemPromptInputProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,6 @@ public function processInput(Input $input): void
PROMPT;
}

$input->setMessageBag($messages->prepend(Message::forSystem($message)));
$input->setMessageBag($messages->withSystemMessage(Message::forSystem($message)));
}
}
3 changes: 1 addition & 2 deletions src/agent/src/Memory/MemoryInputProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,7 @@ public function processInput(Input $input): void
}

$messages = $input->getMessageBag()
->withoutSystemMessage()
->prepend(Message::forSystem($combinedMessage));
->withSystemMessage(Message::forSystem($combinedMessage));

$input->setMessageBag($messages);
}
Expand Down
2 changes: 1 addition & 1 deletion src/ai-bundle/tests/Command/AgentCallCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ public function testCommandWithSystemPromptDisplaysItOnce()
->willReturnCallback(function (MessageBag $messages) use ($result) {
// Simulate SystemPromptInputProcessor behavior - add system prompt if not present
if (null === $messages->getSystemMessage()) {
$messages->prepend(Message::forSystem('System prompt'));
$messages->withSystemMessage(Message::forSystem('System prompt'));
}

return $result;
Expand Down
7 changes: 5 additions & 2 deletions src/platform/src/Message/MessageBag.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,12 @@ public function withoutSystemMessage(): self
return $messages;
}

public function prepend(MessageInterface $message): self
/**
* Clones the MessageBag without previous system message and prepends the given one.
*/
public function withSystemMessage(SystemMessage $message): self
{
$messages = clone $this;
$messages = $this->withoutSystemMessage();
$messages->messages = array_merge([$message], $messages->messages);

return $messages;
Expand Down
4 changes: 2 additions & 2 deletions src/platform/tests/Message/MessageBagTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,15 +113,15 @@ public function testWithoutSystemMessage()
$this->assertSame('Hello, world!', $userMessage->getContent()[0]->getText());
}

public function testPrepend()
public function testWithSystemMessage()
{
$messageBag = new MessageBag(
Message::ofAssistant('It is time to sleep.'),
Message::ofUser('Hello, world!'),
);

$newMessage = Message::forSystem('My amazing system prompt.');
$newMessageBag = $messageBag->prepend($newMessage);
$newMessageBag = $messageBag->withSystemMessage($newMessage);

$this->assertCount(2, $messageBag);
$this->assertCount(3, $newMessageBag);
Expand Down