[Platform] Improvements on CachedPlatform
#1157
Merged
+46
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guikingone
force-pushed
the
refactor/cached_platform
branch
from
3b3d915 to
c2f9ddc
Compare
carsonbot
added
Bug
Contributor
|
Can you please explain what is the improvement about to be more specific? Thanks |
Contributor
Author
|
Summary added in the PR, sorry for the missing part 🙂 |
OskarStark
force-pushed
the
refactor/cached_platform
branch
from
d836ba8 to
149ff59
Compare
Contributor
|
Thank you @Guikingone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
MonotonicClockas the default implementation forClockInterfaceargument inCachedPlatformto ease tests and improve precision instead ofDatetimeImmutable()CachedPlatform.in thenametag ofCachedPlatformdefinition