[AI Bundle] Trace and display AgentInterface calls in Profiler
#570
Conversation
Griffon-Weglot
changed the title
welcoMattic
changed the title
AgentInterface calls in Profiler
welcoMattic
added
AI Bundle
carsonbot
changed the title
AgentInterface calls in ProfilerAgentInterface calls in Profiler
|
Can you please add a screenshot to the PR header? |
Griffon-Weglot
force-pushed
the
main
branch
4 times, most recently
from
ae4e956 to
c1d32f4
Compare
Griffon-Weglot
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
Griffon-Weglot
force-pushed
the
main
branch
2 times, most recently
from
899f7db to
95d76eb
Compare
|
|
||
| public function collect(Request $request, Response $response, ?\Throwable $exception = null): void | ||
| { | ||
| $this->lateCollect(); |
There was a problem hiding this comment.
It seemed redundant to call late collect since it will be called on kernel.terminate so i've removed it, also it's going againts the idea of implementing LateDataCollectorInterface to me, do you think it's relevant ?
There was a problem hiding this comment.
It was introduced in #173 with the reason - does this change break the profiler on streaming?
There was a problem hiding this comment.
Thanks for working on this @Griffon-Weglot!
One thing that would help is to move the input/output html conversion that is used on the platform calls to some macro, that we can use it on the agent and on the platform. so we wouldn't need to just dump the those.
carsonbot
added
Status: Needs Work
Status: Needs Review
and removed
Status: Needs Review
Status: Needs Work
labels
Griffon-Weglot
force-pushed
the
main
branch
from
556f48a to
67898ff
Compare
Griffon-Weglot
force-pushed
the
main
branch
from
67898ff to
81b39d8
Compare
Griffon-Weglot
force-pushed
the
main
branch
from
81b39d8 to
100cb55
Compare
@chr-hertel to simplify the display i've used |
OskarStark
changed the title
AgentInterface calls in ProfilerAgentInterface calls in Profiler
| $calls = $platform->calls; | ||
| foreach ($calls as $key => $call) { | ||
| $result = $call['result']->await(); | ||
|
|
||
| if (isset($platform->resultCache[$result])) { | ||
| $call['result'] = $platform->resultCache[$result]; | ||
| } else { | ||
| $call['result'] = $result->getContent(); | ||
| } | ||
|
|
||
| $calls[$key] = $call; | ||
| } |
There was a problem hiding this comment.
is that necessary? also see #173 for reasoning
|
please bring up the metrics again to the top: |
Sure ! Thanks for your feedbacks i'll make those changes asap |
|
I made a mistake with my fork by commiting in my main branch, this issue is closed for now but i'll try to redo it |
5 participants
Uh oh!
There was an error while loading. Please reload this page.