Skip to content

Conversation

@natewiebe13
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
Docs? no
License MIT

Currently, Qdrant PUT operations are async. This forces the user to add checking after the request happens to determine if it was successful or not.

This adds an option to make operations sync so you can handle any errors immediately instead of polling after until the operation completes.

@carsonbot carsonbot changed the title Qdrant sync Qdrant sync Nov 4, 2025
@natewiebe13 natewiebe13 force-pushed the qdrant-sync branch 3 times, most recently from 33fa2a6 to fcc0b5c Compare November 4, 2025 16:00
@natewiebe13 natewiebe13 changed the title Qdrant sync [Store] Qdrant sync Nov 4, 2025
@chr-hertel
Copy link
Member

But it still makes sense to have that async capabilities as well? sounds like usually one wouldn't want that?
cc @Guikingone do you have an opinion here?

@natewiebe13
Copy link
Contributor Author

@chr-hertel I took the approach of keeping the existing functionality working as-is. But if you're suggesting to always make the PUT synchronous, I'm happy to update the PR. I do find it slightly odd that Qdrant chose to make operations async by default.

Here's a related issue: qdrant/qdrant#2557 which is actually the exact issue I originally ran into when first using Qdrant. But now I'm hitting other issues related to inserts. So now waiting for a response makes way more sense for my situation.

@OskarStark
Copy link
Contributor

lets use async default false, its more the standard case I would say

@chr-hertel
Copy link
Member

Yes, think so too 👍

@Guikingone
Copy link
Contributor

Agree with @OskarStark on this one, let use false as the default case.

@natewiebe13 natewiebe13 force-pushed the qdrant-sync branch 2 times, most recently from 59d8ba3 to 693fc5a Compare November 5, 2025 14:15
@natewiebe13
Copy link
Contributor Author

natewiebe13 commented Nov 5, 2025

Updated the default behavior to synchronously add documents

@carsonbot carsonbot changed the title [Store] Qdrant sync Qdrant sync Nov 6, 2025
@OskarStark
Copy link
Contributor

Thank you @natewiebe13.

@OskarStark OskarStark merged commit 68fbf80 into symfony:main Nov 6, 2025
14 checks passed
@natewiebe13 natewiebe13 deleted the qdrant-sync branch November 7, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants