[Cache][Config][Console][DependencyInjection][FrameworkBundle] Remove dead code and useless casts

Author: alexandre-daubois

Command/CompleteCommand.php

@@ -98,13 +98,13 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 '',
                 '<comment>'.date('Y-m-d H:i:s').'</>',
                 '<info>Input:</> <comment>("|" indicates the cursor position)</>',
-                '  '.(string) $completionInput,
+                '  '.$completionInput,
                 '<info>Command:</>',
-                '  '.(string) implode(' ', $_SERVER['argv']),
+                '  '.implode(' ', $_SERVER['argv']),
                 '<info>Messages:</>',
             ]);
 
-            $command = $this->findCommand($completionInput, $output);
+            $command = $this->findCommand($completionInput);
             if (null === $command) {
                 $this->log('  No command found, completing using the Application class.');
 
@@ -185,7 +185,7 @@ private function createCompletionInput(InputInterface $input): CompletionInput
         return $completionInput;
     }
 
-    private function findCommand(CompletionInput $completionInput, OutputInterface $output): ?Command
+    private function findCommand(CompletionInput $completionInput): ?Command
     {
         try {
             $inputName = $completionInput->getFirstArgument();

Descriptor/ReStructuredTextDescriptor.php

@@ -92,7 +92,7 @@ protected function describeInputOption(InputOption $option, array $options = [])
     protected function describeInputDefinition(InputDefinition $definition, array $options = []): void
     {
         if ($showArguments = ((bool) $definition->getArguments())) {
-            $this->write("Arguments\n".str_repeat($this->subsubsectionChar, 9))."\n\n";
+            $this->write("Arguments\n".str_repeat($this->subsubsectionChar, 9));
             foreach ($definition->getArguments() as $argument) {
                 $this->write("\n\n");
                 $this->describeInputArgument($argument);

Descriptor/XmlDescriptor.php

@@ -208,11 +208,9 @@ private function getInputOptionDocument(InputOption $option): \DOMDocument
             $defaults = \is_array($option->getDefault()) ? $option->getDefault() : (\is_bool($option->getDefault()) ? [var_export($option->getDefault(), true)] : ($option->getDefault() ? [$option->getDefault()] : []));
             $objectXML->appendChild($defaultsXML = $dom->createElement('defaults'));
 
-            if ($defaults) {
-                foreach ($defaults as $default) {
-                    $defaultsXML->appendChild($defaultXML = $dom->createElement('default'));
-                    $defaultXML->appendChild($dom->createTextNode($default));
-                }
+            foreach ($defaults as $default) {
+                $defaultsXML->appendChild($defaultXML = $dom->createElement('default'));
+                $defaultXML->appendChild($dom->createTextNode($default));
             }
         }
 

Output/AnsiColorMode.php

@@ -62,7 +62,7 @@ public function convertFromHexToAnsiColorCode(string $hexColor): string
 
         return match ($this) {
             self::Ansi4 => (string) $this->convertFromRGB($r, $g, $b),
-            self::Ansi8 => '8;5;'.((string) $this->convertFromRGB($r, $g, $b)),
+            self::Ansi8 => '8;5;'.$this->convertFromRGB($r, $g, $b),
             self::Ansi24 => \sprintf('8;2;%d;%d;%d', $r, $g, $b),
         };
     }

Output/TrimmedBufferOutput.php

@@ -53,6 +53,6 @@ protected function doWrite(string $message, bool $newline): void
             $this->buffer .= \PHP_EOL;
         }
 
-        $this->buffer = substr($this->buffer, 0 - $this->maxLength);
+        $this->buffer = substr($this->buffer, -$this->maxLength);
     }
 }