Copy extra.symfony.require when unpacking#443
Merged
fabpot merged 1 commit intosymfony:masterfrom Dec 11, 2018
nicolas-grekas:unpack-wildcard
Merged
Copy extra.symfony.require when unpacking#443fabpot merged 1 commit intosymfony:masterfrom nicolas-grekas:unpack-wildcard
fabpot merged 1 commit intosymfony:masterfrom
nicolas-grekas:unpack-wildcard
Conversation
fabpot
reviewed
Dec 11, 2018
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Dec 11, 2018
This PR was merged into the 1.1-dev branch.
Discussion
----------
Copy extra.symfony.require when unpacking
eg when unpacking the test pack:
```diff
--- a/composer.json
+++ b/composer.json
@@ -5,11 +5,14 @@
"php": "^7.1.3",
"ext-ctype": "*",
"ext-iconv": "*",
+ "symfony/browser-kit": "4.2.*",
"symfony/console": "4.2.*",
+ "symfony/css-selector": "4.2.*",
"symfony/dotenv": "4.2.*",
"symfony/flex": "^1.1",
"symfony/framework-bundle": "4.2.*",
- "symfony/test-pack": "^1.0",
+ "symfony/panther": "*",
+ "symfony/phpunit-bridge": "4.2.*",
"symfony/yaml": "4.2.*"
},
```
Commits
-------
7f685f6 Copy extra.symfony.require when unpacking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eg when unpacking the test pack: