Skip to content

Fix copy from package with directories #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
May 14, 2021
Merged

Fix copy from package with directories #756

nicolas-grekas merged 1 commit into from
May 14, 2021

Conversation

@mnocon
Copy link
Contributor

@mnocon mnocon commented Apr 23, 2021

Potential fix for #755

I've:

  1. added a test that uncovers the issue - even when force is used the existing files are not overwritten
  2. added a test that makes sure the behaviour does not change when force is not used
  3. fixed the issue by respecting the force option in copyDir method.

@mnocon mnocon mentioned this pull request Apr 23, 2021
Closed
@nicolas-grekas
Copy link
Member

nicolas-grekas commented May 14, 2021

Thank you @mnocon.

@nicolas-grekas nicolas-grekas merged commit d7cd877 into symfony:main May 14, 2021
@xabbuh xabbuh mentioned this pull request Jul 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mnocon @nicolas-grekas