Don't try to update package.json on composer install #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
May 14, 2021
Member
|
Thank you @nicolas-grekas. |
Seldaek
reviewed
May 14, 2021
|
|
||
| if (!$recipes) { | ||
| $this->synchronizePackageJson($rootDir); | ||
| if (ScriptEvents::POST_UPDATE_CMD === $event->getName()) { |
Member
There was a problem hiding this comment.
This is borked, $event can be null when called via
Line 376 in ff85b54
I'm not sure how to best fix this sorry so will leave that to you :)
Stack trace if it helps:
Fatal error: Uncaught Error: Call to a member function getName() on null in /home/runner/work/vendor/symfony/flex/src/Flex.php:486
Stack trace:
#0 /home/runner/work/vendor/symfony/flex/src/Flex.php(395): Symfony\Flex\Flex->install()
#1 /home/runner/work/vendor/symfony/flex/src/Flex.php(376): Symfony\Flex\Flex->update()
#2 [internal function]: Symfony\Flex\Flex->checkForUpdate()
#3 phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php(174): call_user_func()
#4 phar:///usr/local/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php(119): Composer\EventDispatcher\EventDispatcher->doDispatch()
#5 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(432): Composer\EventDispatcher\EventDispatcher->dispatchPackageEvent()
#6 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(447): Composer\Installer\InstallationManager->Composer\Installer\{closure}()
#7 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(368): Composer\Installer\InstallationManager->executeBatch()
#8 phar:///usr/local/bin/composer/src/Composer/Installer/InstallationManager.php(267): Composer\Installer\InstallationManager->downloadAndExecuteBatch()
#9 phar:///usr/local/bin/composer/src/Composer/Installer.php(707): Composer\Installer\InstallationManager->execute()
#10 phar:///usr/local/bin/composer/src/Composer/Installer.php(544): Composer\Installer->doInstall()
#11 phar:///usr/local/bin/composer/src/Composer/Installer.php(247): Composer\Installer->doUpdate()
#12 phar:///usr/local/bin/composer/src/Composer/Command/UpdateCommand.php(236): Composer\Installer->run()
#13 phar:///usr/local/bin/composer/vendor/symfony/console/Command/Command.php(245): Composer\Command\UpdateCommand->execute()
#14 phar:///usr/local/bin/composer/vendor/symfony/console/Application.php(835): Symfony\Component\Console\Command\Command->run()
#15 phar:///usr/local/bin/composer/vendor/symfony/console/Application.php(185): Symfony\Component\Console\Application->doRunCommand()
#16 phar:///usr/local/bin/composer/src/Composer/Console/Application.php(310): Symfony\Component\Console\Application->doRun()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
composer install should be read-only, so this doesn't make much sense and this spams the console with unneeded messages.