Make:entity --regenerate : OneToOne relationship bug in the setter

[JayPe69]

Hello,

I have one entity Organization with a team property

class RefOrganization

    /**
     * One Organization has One team
     * @ORM\OneToOne(targetEntity="RefTeam", mappedBy="organization")
     */
    private $team;

I have a second entity Team with a Organization property

class RefTeam

    /**
     * One Team has one Organization
     * @ORM\OneToOne(targetEntity="RefOrganization", inversedBy="team")
     * @ORM\JoinColumn(name="ORGANIZATION_ID", referencedColumnName="ID", nullable=true)
     */
    private $organization;

With the following code, I got a OneToOne relationship between both entities.
However, when lauching the Make:Entity --regenerate to get back all setters / getters,

In the RefOrganization entity, it generates the following setter for the team :

    public function setTeam(?RefTeam $team): self
    {
        $this->team = $team;

        // set (or unset) the owning side of the relation if necessary
        $newOrganization = $team === null ? null : $this;
        if ($newOrganization !== $team->getOrganization()) {
            $team->setOrganization($newOrganization);
        }

        return $this;
    }

When creating the RefOrganization without team (as it's nullable), we have an error because of the :

if ($newOrganization !== $team->getOrganization()) 

call method getOrganization of null object

Regards

[JayPe69]

    public function setTeam(?RefTeam $team): self
    {
      // unset the owning side of the relation if necessary
      if ($this->team !== null && $team === null) {
        $this->team->setOrganization(null);
      } else {
        // set the owning side of the relation if necessary
        if ($team !== null && $this !== $team->getOrganization()) {
            $team->setOrganization($this);
        }
      }
      $this->team = $team;

      return $this;        
    }

This code works

[weaverryan]

Yep, this looks like a bug in the generated code.

[elementaire]

Both codes of the bundle and the proposal of JayPe69 are buggy.

I think, it should be :

public function setTeam(?RefTeam $team): self
{
  if ($this->team) {
    $this->team->setOrganization(null);
  }

  if ($team) {
    $team->setOrganization($this);
  }

  $this->team = $team;

  return $this;
}

[JayPe69]

yep you are right :), if you keep the current code it could be :

public function setTeam(?RefTeam $team): self
{
  if ($this->team) {
    $this->team->setOrganization(null);
  }

  if ($team !== null && $this !== $team->getOrganization()) {
    $team->setOrganization($this);
  }

  $this->team = $team;

  return $this;
}

[yizhihouzi]

one year passed,this question has not been resolved!

[yizhihouzi]

yep you are right :), if you keep the current code it could be :

public function setTeam(?RefTeam $team): self
{
  if ($this->team) {
    $this->team->setOrganization(null);
  }

  if ($team !== null && $this !== $team->getOrganization()) {
    $team->setOrganization($this);
  }

  $this->team = $team;

  return $this;
}

but the team's organization may not be nullable.

[devozanges]

it's so weird that this simplistic mistake hasn't been fixed since then.
There are many ways to do it better...

Bump, similar issue here...

[CODEheures]

Still bugged... My solution

public function setTeam(?RefTeam $team): self
    {

       if ($this->team) {
    		$this->team->setOrganization(null);
	}
       
        $this->team = $team;

        // set (or unset) the owning side of the relation if necessary
        $newOrganization = $team === null ? null : $this;
        if ($team && $newOrganization !== $team->getOrganization()) {
            $team->setOrganization($newOrganization);
        }

        return $this;
    }

[Kocal]

Hi 👋

I've also faced the issue and this is how I fixed it:

public function setUser(?User $user): void
{
    if ($user === null && $this->user !== null) {
        $this->user->setRegion(null);
    }
 
    if ($user !== null && $user->getRegion() !== $this) {
        $user->setRegion($this);
    }
  
    $this->user = $user;
}

This solution prevents:

• an useless call to setRegion(null) when $user is not null
• an infinite loop if User#setRegion() is calling Region#setUser()

I can try to make a PR for fixing this behaviour. I hope there are already tests for this! 😄

EDIT: PR opened at #755

[hosseinsalemi]

Same problem, It didn't fix.
version: v1.43.0.